Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Latest firefox not firing clean disconnect on browser refresh #2357

Closed
davidfowl opened this Issue · 3 comments

3 participants

@davidfowl
Owner

The server is self hosted and the connection is cross domain using long polling (not jsonp).

@DamianEdwards

This repros without self-host or cross domain.

@DamianEdwards

Seems Firefox prevents synchronous ajax from window.unload: http://forums.mozillazine.org/viewtopic.php?f=25&p=12964775

I've confirmed that changing to async ajax on window.unload makes Firefox work, but it breaks Chrome :cry:

We may have to browser sniff and conditionally fire the abort Ajax request as sync/async depending on the browser.

@DamianEdwards DamianEdwards referenced this issue from a commit
@DamianEdwards DamianEdwards Fix Firefox not disconnecting on refresh
- Change the withCredentials flag to only be auto-set when cross-domain is detected (can still be explicitly set)
- Conditionally do an async abort if the browser is Firefox 11+ AND withCredentials is true
- #2357
b38db89
@DamianEdwards DamianEdwards referenced this issue from a commit
@DamianEdwards DamianEdwards Added unit tests for Firefox disconnect on refresh
- Crated a new QUnit extension to enable theories (data-driven tests)
- Other minor JS test project fixes/shuffling
- #2357
82b8519
@DamianEdwards DamianEdwards referenced this issue
Closed

2357 #2365

@DamianEdwards DamianEdwards referenced this issue from a commit
@DamianEdwards DamianEdwards Fix Firefox not disconnecting on refresh
- Change the withCredentials flag to only be auto-set when cross-domain is detected (can still be explicitly set)
- Conditionally do an async abort if the browser is Firefox 11+ AND withCredentials is true
- #2357
458589c
@DamianEdwards DamianEdwards referenced this issue from a commit
@DamianEdwards DamianEdwards Added unit tests for Firefox disconnect on refresh
- Crated a new QUnit extension to enable theories (data-driven tests)
- Other minor JS test project fixes/shuffling
- #2357
1f4568f
@gustavo-armenta

tested on IE setting on debugger connection.withCredentials = true and connection.stop() is sync.
tested on Firefox11 setting on debugger connection.withCredentials = true and connection.transport.abort(connection, async) is called with async = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.