Microsoft Platform Ready Test Tool complains that the dlls do not have a valid Product Name property #2471

Closed
KrzysFR opened this Issue Aug 29, 2013 · 6 comments

Projects

None yet

5 participants

Contributor
KrzysFR commented Aug 29, 2013

When using the Microsoft Plateform Ready Test Tool, it complains that the SignalR dll do not have a valid "Product Name" property on Test Case TC2.2

The assemblies do have a 'Product Version' and 'Company Name', but only the 'Product Name' seems to be missing

image

Here is the log of the test case in question:

======================================================================
Log generated by Microsoft Platform Ready Test Tool - Version 4.1.0.0 | Signed: mercredi, mars 27, 2013
======================================================================
    Test name: AcmeFooBar
    Test date: 08/28/2013 14:20:13
    Tested on: Virtual Machine on Microsoft Windows Server 2012 Hyper-V
    Test for: Windows Server 2012
======================================================================
Test case/Verification: TC2.2 - Check if application binaries have valid file version information
======================================================================

 Add valid file information to owned binaries.

 Binaries not built by product group or company can be considered 3rd party.
 Binaries without proper file version information will fail this test case. No waiver is required for this optional test case.

 Interop files do not provide file information by design, and are excluded from this list.

======================================================================

08/28/2013 14:20:13 :: Binary list
... snip snip ...
C:\Program Files\Acme\FooBar\Microsoft.AspNet.SignalR.Client.dll does not have a valid "Product name" property.
C:\Program Files\Acme\FooBar\Microsoft.AspNet.SignalR.Core.dll does not have a valid "Product name" property.

I'm using the Nuget package for 2.0.0-rc1 as the source of the assemblies.

Contributor
KrzysFR commented Aug 29, 2013

And I forgot to add that it is also complaining of a lack of Authenticode signature in test TC2.3

======================================================================
Log generated by Microsoft Platform Ready Test Tool - Version 4.1.0.0 | Signed: mercredi, mars 27, 2013
======================================================================
    Test name: AcmeFooBar
    Test date: 08/28/2013 14:19:56
    Tested on: Virtual Machine on Microsoft Windows Server 2012 Hyper-V
    Test for: Windows Server 2012
======================================================================
Test case/Verification: TC2.3 - All binaries and installers must be Authenticode signed
======================================================================

 Authenticode sign all setup files and binaries installed by the application.
 Binaries not built by product group or company can be considered 3rd party.
 3rd party binaries without valid signatures will fail this test case. No waiver is required for this optional test case.
======================================================================
08/28/2013 14:19:56 :: Binary list

08/28/2013 14:20:07 :: The following binaries failed signature verification:

C:\Program Files\Acme\FooBar\Microsoft.AspNet.SignalR.Client.dll
C:\Program Files\Acme\FooBar\Microsoft.AspNet.SignalR.Core.dll
Owner

Can you run this same tool on MVC and webapi? Assuming you got these dlls from nuget, we use the same process for all of those assemblies and the "Digital Signatures" tab in the above picture shows that they've been authenticode signed as well.

Contributor
KrzysFR commented Aug 29, 2013

I'm not the one running the test suite so I can't answer that immediately. But from memory I'm also using the Razor assembly (the core one, with just the parsers and stuff) and it did not show up in the list.

This is test case seems to be optional so it's not super critical.

I'll try seeing with my colleague who runs the test if we can put the MVC assemblies in there and see if they trigger something. But this will be tomorrow at best.

Contributor
KrzysFR commented Aug 29, 2013

Oh ok, the screen capture is from my master/dev branch, but the test suite was running on a different 'release' branch that was running an older version of SignalR. The assemblies missing the authenticode were from a custom build SignalR v1.1. Sorry about the mixup.

The 2.0-rc1 assemblies from nuget do have authenticode signatures, and are only missing the product name. That seems to have been fixed by Damian's commit.

Owner

Closing this.

@davidfowl davidfowl closed this Aug 29, 2013
@davidfowl davidfowl reopened this Aug 30, 2013
@Xiaohongt Xiaohongt was assigned Aug 30, 2013
Contributor

verified that all SignalR assemblies have "Microsoft ASP.NET SignalR" product name

@Xiaohongt Xiaohongt closed this Oct 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment