Improve logging on the JS client #2487

Closed
halter73 opened this Issue Sep 5, 2013 · 1 comment

Projects

None yet

4 participants

Member
halter73 commented Sep 5, 2013

Will update this bug with the little things that we can change to make the logging consistent between transports and also improve logging.

More consistent logging:

## WS
[19:38:00 PDT] SignalR: Negotiating with '../raw-connection/negotiate?clientProtocol=1.3'. 
[19:38:00 PDT] SignalR: Connecting to websocket endpoint 'ws://localhost:40476/raw-connection/connect?transport=webSockets&connectionToken=mgt%2FXxLMkeA%2BbkLa6zyX6EvVSW7OG%2F0ZYdl9vjJSH5L5UqczitB2XrOAyz5FH7gSfufL0J6xhxsSxdKCPPeeM2ib0jj2JAD8bmmoGWjMDPmSDgIBumwr2VuyJzplipzX&tid=6' 
[19:38:00 PDT] SignalR: Websocket opened 
[19:38:00 PDT] SignalR: Now monitoring keep alive with a warning timeout of 13333.333333333332 and a connection lost timeout of 20000 

## FF
[19:38:26 PDT] SignalR: Negotiating with '../raw-connection/negotiate?clientProtocol=1.3'. 
[19:38:26 PDT] SignalR: Binding to iframe's readystatechange event. 
[19:38:26 PDT] SignalR: Now monitoring keep alive with a warning timeout of 13333.333333333332 and a connection lost timeout of 20000 

## SSE
[19:39:38 GMT-0700 (Pacific Daylight Time)] SignalR: Negotiating with '../raw-connection/negotiate?clientProtocol=1.3'. jquery.signalR.js:75
[19:39:38 GMT-0700 (Pacific Daylight Time)] SignalR: Attempting to connect to SSE endpoint 'http://localhost:40476/raw-connection/connect?transport=serverSentEvents&co…ZfJ%2BL8u9S1w6gC5DGWVoVVnoOwSDwkIP9Y6tRJwhwlsJUwhQcQFmaiWc6K8nA50bdL&tid=4' jquery.signalR.js:75
[19:39:39 GMT-0700 (Pacific Daylight Time)] SignalR: EventSource connected jquery.signalR.js:75
[19:39:39 GMT-0700 (Pacific Daylight Time)] SignalR: Now monitoring keep alive with a warning timeout of 13333.333333333332 and a connection lost timeout of 20000 jquery.signalR.js:75

## LP
[19:38:45 PDT] SignalR: Negotiating with '../raw-connection/negotiate?clientProtocol=1.3'. 
[19:38:45 PDT] SignalR: Attempting to connect to 'http://localhost:40476/raw-connection/connect?transport=longPolling&connectionToken=lE3AHbEPGJ1GeEXxxTrC7m2YbTdBFBMDzskfwaDiwaD1wkhh1CcRc9fL6fBsEwzWOsAotbgnxnQzmfG6uoV3et8seBVFoK7gxDPoXvW%2BTYwpTWhzxMqolOGgYTMK3u%2FS&tid=1' using longPolling. 
[19:38:45 PDT] SignalR: Attempting to connect to 'http://localhost:40476/raw-connection/poll?transport=longPolling&connectionToken=lE3AHbEPGJ1GeEXxxTrC7m2YbTdBFBMDzskfwaDiwaD1wkhh1CcRc9fL6fBsEwzWOsAotbgnxnQzmfG6uoV3et8seBVFoK7gxDPoXvW%2BTYwpTWhzxMqolOGgYTMK3u%2FS&groupsToken=fCxjst%2F2xTtZnbNAZ32aqX9%2Fvp4iZYK41yDxaLjrvG%2FMal8F25MLlT5odVjrYz1jvxYYYQhKsxKTmDlmNlfUwihPxpOSwXNW9lQ%2FYsA6BKaCusLPY%2FwkOjoM7FoqwPlWZ%2BNl8sY9BRWdwKMRZ84wb6e18F3vQB4kr29kKvaDS%2FBRsPeJDB26EwJ4bQFz%2Bdq%2F&messageId=d-37651B43-B%2C6%7CJ%2C1%7CK%2C0%7CE%2C0&tid=2' using longPolling. 
[19:38:45 PDT] SignalR: LongPolling connected 
[19:38:45 PDT] SignalR: Attempting to connect to 'http://localhost:40476/raw-connection/poll?transport=longPolling&connectionToken=lE3AHbEPGJ1GeEXxxTrC7m2YbTdBFBMDzskfwaDiwaD1wkhh1CcRc9fL6fBsEwzWOsAotbgnxnQzmfG6uoV3et8seBVFoK7gxDPoXvW%2BTYwpTWhzxMqolOGgYTMK3u%2FS&groupsToken=fCxjst%2F2xTtZnbNAZ32aqX9%2Fvp4iZYK41yDxaLjrvG%2FMal8F25MLlT5odVjrYz1jvxYYYQhKsxKTmDlmNlfUwihPxpOSwXNW9lQ%2FYsA6BKaCusLPY%2FwkOjoM7FoqwPlWZ%2BNl8sY9BRWdwKMRZ84wb6e18F3vQB4kr29kKvaDS%2FBRsPeJDB26EwJ4bQFz%2Bdq%2F&messageId=d-37651B43-B%2C7%7CJ%2C2%7CK%2C0%7CE%2C0&tid=7' using longPolling. 

  • We need to update forever frame to show iframe connected (or something similar).
  • LongPolling always says "Attempting to connect to {url}", we should change that "attempting" to something else since it makes it look like if it attempted and there's no confirmation that it succeeded.

#2366

@NTaylorMullen NTaylorMullen added a commit that referenced this issue Oct 3, 2013
@NTaylorMullen NTaylorMullen Made logging more consistent throughout the code base.
- Added periods to the end of every log line.
- Removed "SignalR:" from beginning of logged lines so it wasn't logged twice.
- Re-worded some language.
- Added Long poll complete log.
- Made it so the clearing hub invocation log is only called if callbacks are available to be cleared.

#2487
d0051ca
Contributor

verified changes are similar to #2366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment