Swallow some exceptions on the server so they don't get logged #2522

Closed
halter73 opened this Issue Sep 5, 2013 · 1 comment

4 participants

@halter73
SignalR member

We've always had several reports of users complaining that their logs are full of errors they can't filter because of exceptions that occur when using SignalR. These aren't actually a problem, but the fact that they show up in logs makes people worry about them and makes them file bugs. The best thing to do would be to swallow these errors trace them and return a non faulted task (if possible).

Examples of bug reports
#1942
#2447
#2393
#1998

#2450

@davidfowl davidfowl was assigned Oct 15, 2013
@halter73 halter73 was assigned Oct 24, 2013
@halter73 halter73 added a commit that referenced this issue Nov 1, 2013
@halter73 halter73 Respond to bad requests with a 400 status code
- Previously bad requests caused PersistentConnection.ProcessRequest to throw
  resulting in a 500
- Respond with a 403 status code when the client changes identity
- No longer throwing on bad requests reduces extraneous error logging
- #2522
961398c
@halter73 halter73 added a commit that referenced this issue Nov 1, 2013
@halter73 halter73 Traces logged by TaskAsynceHelper.Catch are now warnings
- This should make it easier to filter out those traces

#2522
db1e740
@halter73 halter73 added a commit that referenced this issue Nov 2, 2013
@halter73 halter73 Respond to bad requests with a 400 status code
- Previously bad requests caused PersistentConnection.ProcessRequest to throw
  resulting in a 500
- Respond with a 403 status code when the client changes identity
- No longer throwing on bad requests reduces extraneous error logging

#2522
9a212bb
@halter73 halter73 added a commit that referenced this issue Nov 2, 2013
@halter73 halter73 Traces logged by TaskAsynceHelper.Catch are now warnings
- This should make it easier to filter out those traces

#2522
031fda2
@halter73 halter73 added a commit that referenced this issue Nov 2, 2013
@halter73 halter73 Respond to bad requests with a 400 status code
- Previously bad requests caused PersistentConnection.ProcessRequest to throw
  resulting in a 500
- Respond with a 403 status code when the client changes identity
- No longer throwing on bad requests reduces extraneous error logging

#2522
5b72d35
@halter73 halter73 added a commit that referenced this issue Nov 2, 2013
@halter73 halter73 Traces logged by TaskAsynceHelper.Catch are now warnings
- This should make it easier to filter out those traces

#2522
daaa834
@halter73 halter73 added a commit that referenced this issue Nov 8, 2013
@halter73 halter73 Respond to bad requests with a 400 status code
- Previously bad requests caused PersistentConnection.ProcessRequest to throw
  resulting in a 500
- Respond with a 403 status code when the client changes identity
- No longer throwing on bad requests reduces extraneous error logging

#2522
61337fd
@halter73 halter73 added a commit that referenced this issue Nov 8, 2013
@halter73 halter73 Traces logged by TaskAsynceHelper.Catch are now warnings
- This should make it easier to filter out those traces

#2522
aca485d
@gustavo-armenta

using Fiddler, tested invalid websocket requests return a 400 and there is no error on log file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment