Skip to content

in ServiceBus scale-out, exception for unresolved endpoint is not handled and it will crash the process #2542

Closed
Xiaohongt opened this Issue Sep 12, 2013 · 4 comments

3 participants

@Xiaohongt
SignalR member

Similar as issue#2541, but the exception in different place not handled.

Functional impact:
the process get killed, for iis, all other apps in the app pool will get killed too

Note,
this repro on both 2.0/2.0.1 and 1.1.3/1.1.4

e.g. Use ServiceBus scale-out, Connection String "Endpoint=sb://signalrtest13.servicebus.windows.net/;SharedSecretIssuer=owner;SharedSecretValue=jZsPBWuB85GY4KW9AT7fWUlX1SLn/fhD7py9QUm9i21=";

when the Endpoint=sb://signalrtest13.servicebus.windows.net/ which can't be resolved:
in 2.0 Servicebus scale-out source code ServiceBusConnection.cs, the code will get exception which is not handled:

if (!_namespaceManager.TopicExists(topicName))

in 2.0.1 Servicebus scale-out source code in retry the exception are still not handled:

                catch (UnauthorizedAccessException ex)
                {
                    _trace.TraceError(errorMessage, ex.Message);
                    throw;
                }
                catch (QuotaExceededException ex)
                {
                    _trace.TraceError(errorMessage, ex.Message);
                    throw;
                }
                catch (MessagingException ex)
                {
                    _trace.TraceError(errorMessage, ex.Message);
                    if (ex.IsTransient)
                    {
                        Thread.Sleep(RetryDelay);
                    }
                    else
                    {
                        throw;
                    }
                }
@abnanda1 abnanda1 was assigned Sep 12, 2013
@abnanda1

@davidfowl if its killing all the apps in the app pool..we should just trace the exception and not throw it again?

@abnanda1 abnanda1 added a commit that referenced this issue Sep 18, 2013
@abnanda1 abnanda1 Made changes to not throw exceptions in case of configuration, author…
…ization or messaging errors in Service Bus.


#2542   #2541
c879fe7
@abnanda1 abnanda1 added a commit that referenced this issue Sep 19, 2013
@abnanda1 abnanda1 Made changes to not throw exceptions in case of config, auth or messa…
…ging errors in Service Bus


#2542 #2541
8dc3ac4
@abnanda1 abnanda1 added a commit that referenced this issue Sep 23, 2013
@abnanda1 abnanda1 Made changes to not throw exceptions in case of config, auth or messa…
…ging errors in Service Bus


#2542 #2541
3a502ac
@abnanda1 abnanda1 added a commit that referenced this issue Sep 30, 2013
@abnanda1 abnanda1 Made changes to not throw exceptions in case of config, auth or messa…
…ging errors in Service Bus


#2542 #2541
c6ffb08
@davidfowl
SignalR member

@abnanda1 is this fixed?

@abnanda1

Yeah it is...forgot to assign it to Xiaohong for verification.

@Xiaohongt Xiaohongt was assigned Oct 15, 2013
@Xiaohongt
SignalR member

verified that process not crash anymore in this case

@Xiaohongt Xiaohongt closed this Oct 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.