Connection.Start in the .NET client re-initializes state variables regardless of the connection status #2683

Closed
DamianEdwards opened this Issue Nov 5, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@DamianEdwards
Member

DamianEdwards commented Nov 5, 2013

Found during work on on fix for #2653

The Connection.Start method in the .NET client initializes instance state variables, e.g. _startTcs, before checking the state of the connection.

This means that if you call Start().Wait() twice in a row, the second call to Start will blast away the state of the connection, resulting in strange errors (as the internal state is now essentially in a corrupt state).

Port from #2675

@ghost ghost assigned DamianEdwards Nov 5, 2013

DamianEdwards added a commit that referenced this issue Nov 5, 2013

@ghost ghost assigned gustavo-armenta Nov 6, 2013

@gustavo-armenta

This comment has been minimized.

Show comment
Hide comment
@gustavo-armenta

gustavo-armenta Nov 7, 2013

Contributor

ran test "ConnectionFunctionsCorrectlyAfterCallingStartMutlipleTimes"

Contributor

gustavo-armenta commented Nov 7, 2013

ran test "ConnectionFunctionsCorrectlyAfterCallingStartMutlipleTimes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment