Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingalR performance counters with Azure SDK 2.6 #3511

Closed
ghost opened this issue Jul 6, 2015 · 4 comments
Closed

SingalR performance counters with Azure SDK 2.6 #3511

ghost opened this issue Jul 6, 2015 · 4 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Jul 6, 2015

There is a good article explaining how to enable SignalR performance counters on Azure web roles:

Using SignalR Performance Counters in an Azure Web Role

However, in Azure SDK 2.6 diagnostics through code is entirely deprecated (SignalRDiagnosticHelper class) and everything must be configured in xml file diagnostics.wadcfgx.

Does it mean that it is enough simply to move definitions of performance counters to the xml configuration file? If so, how should we be with dynamic category names? Or can this still lead to troubles due to diagnostics monitor starting before the role starts?

P.S. It would be also nice to have the asp.net article updated with the latest SDK 2.6 changes.

@kirthiroyadu
Copy link

Any changes/updates to this? The article still uses the deprecated code.

@analogrelay
Copy link
Contributor

I did some reviewing of the doc. It's quite out of date. I can assemble an outline for building a new one. The dynamic category names are a small problem, but you can register for all of instances of the SignalR counters by using \SignalR(*)\[Counter Name] as the path. For example \SignalR(*)\Connections Current.

/cc @muratg @moozzyk

@analogrelay analogrelay added this to the 2.2.2 milestone Jan 26, 2017
@analogrelay
Copy link
Contributor

I confirmed that if you move the Performance Counters to the xml file and use \SignalR(*)\[SignalR Counter Name] as the path, it does work.

@analogrelay
Copy link
Contributor

Logged a bug to fix the doc: dotnet/AspNetCore.Docs#2636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants