WebSockets transport cannot differentiate between graceful/ungraceful disconnect #735

Closed
NTaylorMullen opened this Issue Sep 28, 2012 · 1 comment

Projects

None yet

2 participants

@NTaylorMullen

Currently WebSockets treats all closes equivalently.

Need to add logic that allows WebSockets to force a client disconnect on: Ungraceful Disconnect && Connection ID removed from Heartbeat.

Note: For fatal exceptions we trigger an error but still close the socket the same way.

@NTaylorMullen NTaylorMullen added a commit that referenced this issue Oct 2, 2012
@NTaylorMullen NTaylorMullen WebSockets now detect disgraceful closes
Added new OnUngracefulClose to the websocket transport.  Made this
change to the WebSocketHandler pieces and to the ServerRequestWebSocket
piece.  I couldn't find where the WebSocketHandler is being used now but
figured I should add the change to it as well.

#735
e6bc5df
@NTaylorMullen NTaylorMullen added a commit that referenced this issue Oct 4, 2012
@NTaylorMullen NTaylorMullen WebSockets now detect disgraceful closes
Added new OnUngracefulClose to the websocket transport.  Made this
change to the WebSocketHandler pieces and to the ServerRequestWebSocket
piece.  I couldn't find where the WebSocketHandler is being used now but
figured I should add the change to it as well.

#735
d75b17c
@NTaylorMullen NTaylorMullen added a commit that referenced this issue Oct 4, 2012
@NTaylorMullen NTaylorMullen Added an indicator to the OnClose to determine if
has been a clean/unclean close.  Also added the same changes to the
WebSocketHandler and DefaultWebSocketHandler for consistencies sake.

#735
6d03262
@Xiaohongt
SignalR member

verified

@Xiaohongt Xiaohongt closed this Oct 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment