RouteTable.Routes.MapHubs(string url) should only allow virtual path, not full url #962

Closed
Xiaohongt opened this Issue Nov 14, 2012 · 7 comments

Comments

Projects
None yet
3 participants
@Xiaohongt
Contributor

Xiaohongt commented Nov 14, 2012

Currently it doesn't throw error when call like below (which doesn't make sense):
RouteTable.Routes.MapHubs("http://localhost/website3") ;

@ghost ghost assigned halter73 Nov 19, 2012

@davidfowl

This comment has been minimized.

Show comment Hide comment
@davidfowl

davidfowl Dec 11, 2012

Member

Virtual path not relative.

Member

davidfowl commented Dec 11, 2012

Virtual path not relative.

@davidfowl

This comment has been minimized.

Show comment Hide comment
@davidfowl

davidfowl Feb 23, 2013

Member

@Xiaohongt Does this still repro with the latest?

Member

davidfowl commented Feb 23, 2013

@Xiaohongt Does this still repro with the latest?

@Xiaohongt

This comment has been minimized.

Show comment Hide comment
@Xiaohongt

Xiaohongt Feb 25, 2013

Contributor

still repro in release branch

Contributor

Xiaohongt commented Feb 25, 2013

still repro in release branch

@davidfowl

This comment has been minimized.

Show comment Hide comment
@davidfowl

davidfowl Feb 25, 2013

Member

@Xiaohongt and by still repro you mean it doesn't throw?

Member

davidfowl commented Feb 25, 2013

@Xiaohongt and by still repro you mean it doesn't throw?

@davidfowl

This comment has been minimized.

Show comment Hide comment
@davidfowl

davidfowl Feb 25, 2013

Member

Do the mvc routes fail when you put in a full url?

Member

davidfowl commented Feb 25, 2013

Do the mvc routes fail when you put in a full url?

@halter73

This comment has been minimized.

Show comment Hide comment
@halter73

halter73 May 22, 2013

Member

Isn't "http://localhost/website3" technically a valid path? As in is there anything invalid about http://www.example.com/http://localhost/website3/signalr?

Member

halter73 commented May 22, 2013

Isn't "http://localhost/website3" technically a valid path? As in is there anything invalid about http://www.example.com/http://localhost/website3/signalr?

@davidfowl

This comment has been minimized.

Show comment Hide comment
@davidfowl

davidfowl Jun 25, 2013

Member

Closing this.

Member

davidfowl commented Jun 25, 2013

Closing this.

@davidfowl davidfowl closed this Jun 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment