Append "/poll" to polling attempts in case the URL ends with "/hubs" #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Append "/poll" to polling attempts in case the URL ends with "/hubs"
- Append "/poll" to polling attempts in case the URL ends with "/hubs"
| @@ -355,7 +355,7 @@ | |||
| if (index >= transports.length) { | |||
| if (!connection.transport) { | |||
| // No transport initialized successfully | |||
| $(connection).triggerHandler(events.onError, "SignalR: No transport could be initialized successfully. Try specifying a different transport or none at all for auto initialization."); | |||
| $(connection).triggerHandler(events.onError, ["SignalR: No transport could be initialized successfully. Try specifying a different transport or none at all for auto initialization."]); | |||
There was a problem hiding this comment.
triggerHandler expects an array.
It came up when I was trying to figure out why my JS test was failing in Chutzpah but not in normal browsers.
I made this change in its own commit.
There was a problem hiding this comment.
Are we missing this in other cases?
|
Make sure you run some tests with old clients and new servers and let @Xiaohongt know as well. |
|
@davidfowl There are absolutely no server-side changes making it impossible for this change to affect old clients. |
|
@halter73 I still want verification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1707