Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color to StreamR #4

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@jkotalik
Copy link

commented Jun 9, 2019

Made a PR to the wrong place.

The only thing I'm concerned about is the performance. We are suddenly sending significantly more bytes per character. Any ideas on how to reduce it are appreciated.

endpoints.MapRazorPages();
endpoints.MapHub<StreamHub>("/stream", o =>
{
//o.TransportMaxBufferSize = 1000000;

This comment has been minimized.

Copy link
@davidfowl

davidfowl Jun 9, 2019

Member

Since you cleaned this up. Remove these.

@@ -7,7 +7,6 @@


<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.App" Version="3.0.0-preview-19075-0444" />
<PackageReference Include="Microsoft.AspNetCore.SignalR" Version="3.0.0-preview-19075-0444" />

This comment has been minimized.

Copy link
@davidfowl

davidfowl Jun 9, 2019

Member

Remove this too? When was this project made?

This comment has been minimized.

Copy link
@BrennanConroy

BrennanConroy Jun 9, 2019

Member

A long time ago :)

@BrennanConroy

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

We are suddenly sending significantly more bytes per character. Any ideas on how to reduce it are appreciated.

Yeah, that was my main concern with adding color. We should come up with a custom compacting format to encode the character + color.

Also, we can switch to MessagePack instead of Json

@jkotalik

This comment has been minimized.

Copy link
Author

commented Jun 17, 2019

I'm going to close this for now and revive it later (when I actually have free time).

@jkotalik jkotalik closed this Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.