Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark json errors, clean json parsing code and implement json schema #1866

Merged

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Apr 16, 2023

Background

we have a lot of issues with json parsing.

Changes

  • Added benchmarks to measure json errors
  • refactored json parsing so that it uses the right methods and has less if conditions
  • used the right method to clean the json
  • implemented json schema so that we have a clean AI input to work with => we need someone to work on feeding the json validations error back to the AI, so that it corrects its json itself (this is a different problem than JSON parsing)

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@waynehamadi
Copy link
Contributor Author

work in progress still, we're testing the benchmark on github action and needs a rebase as well.

@waynehamadi waynehamadi force-pushed the feature/benchmark branch 16 times, most recently from 064bd38 to c3c3674 Compare April 16, 2023 16:21
@waynehamadi waynehamadi changed the title Feature/benchmark benchmark json errors, clean json parsing code and implement json schema Apr 16, 2023
@waynehamadi waynehamadi force-pushed the feature/benchmark branch 6 times, most recently from 9a8a9b2 to 7ba1ead Compare April 16, 2023 16:44
@waynehamadi waynehamadi force-pushed the feature/benchmark branch 2 times, most recently from 069e413 to 557131b Compare April 16, 2023 18:39
@BillSchumacher BillSchumacher merged commit 176f74b into Significant-Gravitas:master Apr 16, 2023
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
…re/benchmark

benchmark json errors, clean json parsing code and implement json schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants