-
Notifications
You must be signed in to change notification settings - Fork 44.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimall add pytest #1859
minimall add pytest #1859
Conversation
@0xArty Changing to
Let me know what you think, I'm open for debate. We could also try & conjure up some ADRs together and split the work. |
Hey @drikusroor Thanks so much for your input and suggestions on the pytest migration. Here's some insight into the current plan:
I truly appreciate your input and willingness to collaborate. Your idea of dividing the work is great, and I'd love to help. Let's work together to make this transition as smooth as possible! This PR is just doing the minimum to get pytest supported. |
@0xArty There are conflicts now |
* minimall add pytest * updated docs and pytest command * proveted milvus integration test running if milvus is not installed
* minimall add pytest * updated docs and pytest command * proveted milvus integration test running if milvus is not installed
Background
This PR aims to introduce
pytest
as the testing framework for our project. While the project currently usesunittest
,pytest
offers several advantages such as improved test discovery, more powerful assertions, and a rich ecosystem of plugins. This change will help improve the quality and maintainability of our test suite.As part of this PR, we are also adding
pytest
as a pre-commit check to ensure that tests are passing before any code is committed to the repository. Additionally, we have included thepytest-integration
plugin, which allows us to better manage and separate integration tests from unit tests.Changes
pytest
andpytest-integration
to the project's dependencies.pytest
.pytest
as a pre-commit check.Documentation
The changes in this PR are documented in the following ways:
README.md
file to mention the use ofpytest
for testing.pytest
features.pytest
and thepytest-integration
plugin.Test Plan
To ensure the functionality of this PR, the following tests were performed:
pytest
to confirm that all tests pass.pytest
syntax and confirmed that they pass.pytest
and prevents committing code with failing tests.pytest-integration
plugin to confirm that they are correctly separated from unit tests.PR Quality Checklist