Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update sourcebans++ native #13

Closed
Drmohammad11 opened this issue Sep 30, 2019 · 5 comments

Comments

@Drmohammad11
Copy link

commented Sep 30, 2019

hi friend!!
please update smac for sourcebans++ !!
why i can not pull requests ??

thank you

@borzaka

This comment has been minimized.

Copy link

commented Sep 30, 2019

I'am using SMAC with SourceBans++ and I have already two permanent bans triggered by SMAC. And they are showing up correctly at the bans page.
I'am using the latest versions and compiled booth myself with 1.9 SourceMod.

@Drmohammad11

This comment has been minimized.

Copy link
Author

commented Sep 30, 2019

i used last version of sbpp V1.7 and sm V1.9 !!
check this:
#define SOURCEBANS_AVAILABLE() (GetFeatureStatus(FeatureType_Native, "SBBanPlayer") == FeatureStatus_Available)
and this:
native void SBPP_BanPlayer(int iAdmin, int iTarget, int iTime, const char[] sReason);
https://github.com/sbpp/sourcebans-pp/blob/b3962fadc549c5da3129530a5c2ea0e8dbc27a63/game/addons/sourcemod/scripting/include/sourcebanspp.inc#L74

@Silenci0

This comment has been minimized.

Copy link
Owner

commented Sep 30, 2019

Ah okay, I see what you are saying. There is a new native for Sourcebans++ and the old native is depreciated. I'll get to updating this as soon as possible to add support for the new native.

As far as pull requests, you should be able to do them as another person has already done so with this repository for Chinese translations. I would be more than happy to accept pull requests/contributions to SMAC, after review of the code of course, as updates/fixes would be much easier if more than myself was working on this.

Regardless, I'll get to work on updating this for all the affected modules and I'll see about trying to push out an update as soon as possible to support Sourcebans++, thank you for making me aware of the issue!

@Silenci0

This comment has been minimized.

Copy link
Owner

commented Oct 1, 2019

Hello,

I have uploaded an update for SMAC to version 0.8.6.6 which includes support for the new Sourcebans++ native. I made sure that the check in Native_Ban would check for the new Sourcebans++ native first, then the depreciated native if it was not found next, with the default ban/kick set as last in the case Sourcebans is not present. I tested that the changes would compile and that the plugins would load on the server and it seems like it is working, but if it does not work, please let me know.

Also, I just noticed that @Drmohammad11 had made a pull request earlier today (#14), but I did not see it prior to uploading my changes. I'm very sorry that I did not notice this. The changes made are pretty much the same as yours except the define is named differently and the order of the if statement in Native_Ban was set so that the new Sourcebans++ native would be checked first since, if left the other way around, it would continue to use the depreciated native as it still exists.

Regardless, thank you for making the pull request and, again, I am very sorry that I did not see it earlier. I will close out the pull request as unaccepted, but know that I would have accepted it had I saw it earlier. Thank you for your work!

I will close this issue in a few days assuming that the plugins are working correctly. Please let me know if there are any further issues.

Thank you,

Silence

@Drmohammad11

This comment has been minimized.

Copy link
Author

commented Oct 2, 2019

i tested new update and this worked for sourcebans++.
thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.