Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
smac commands kick #8
Is it CS:GO that the plugins are being used for or is it another game? Also, do you happen to know what commands might be kicking people or if there are any logs for SMAC on the server that indicate the command module is kicking players? If there are logs, please post them for me (you may want to redact player names and IP info prior to posting) as it can potentially help me narrow down the issue.
EDIT: Also, if its not a command, but command spamming (ie: the plugin is detecting commands that are being spammed too often) that could also be an issue as well. If you have any printed admin messages regarding if it was command spam or a particular command that is being used when players are being kicked, please also include that information.
hello, yep its only on csgo, never had this problem before with "smac.commands.smx" since i updated to the new version I had to remove it.
recently i tried the plugin on a clean server and i didnt get kicked, seems like some plugins are causing this issue with the new version. i will give you more information while im investigating
[SM] Listing 74 plugins:
73 "RankMe" (3.0.3.Kento.31.2) by lok1, Scooby, Kento, pracc, Kxnrl, CrazyHackGUT
Looking into it from the code end, what is getting activated is the command spam portions of the code, which the cvar smac_antispam_cmds controls. By default, it is set to 20 commands per second, so whatever is triggering this is spamming a particular command 20 times in a pretty short period of time.
If you set smac_antispam_cmds to 0 in your smac.cfg file, it should disable the check for command spam. As a test, try to disable it without disabling the plugin and see if you keep getting kicked for command spam.
On another note, I have not updated the code for this module in some time, though I have recompiled the plugin during every update so that it keeps up with the changes in both the includes and the core module, so not much has changed in the module itself. However, since it is kicking people, it should be logging the command (as well as client info) in the "SMAC.log" file in "addons/sourcemod/logs". If that log isn't present, please try to create a log file in that folder named "SMAC.log" and re-enable the plugin's anti-spam feature. If the code is logging everything correctly, it should show the actual command that people are being kicked for.
Thank you for the update!
It looks like snd_setsoundparam is a CS:GO command for adjusting sound parameters and, for whatever reason, it is being spammed somehow. Looking into this further, there was an update on 05/29/2019 regarding this command and it has been removed from CS:GO, so it shouldn't even be an issue. However, for whatever reason, the command is being triggered, so it might possibly be a bug of some sort that came out with a recent release.
Regardless of the reason, it is still causing SMAC to trigger the anti-spam commands. If there is some kind of bind or autoexec.cfg file with this command in it, it may be a good idea to remove it and any instances of it from your client configs. If that isn't the case, then its definitely a client-side thing that is not working correctly. This is definitely a false positive of some sort, so you may want to either:
This should work for now and since the SMAC commands module can add commands to the ignore list, you should be able to simply add it yourself via plugin cvars in your configs. That said, I will be adding this command to the plugin just in case this is a wide spread issue (which it might be), so any of the above three options should suffice until I can update the commands plugin to ignore this particular command. I will also be adding a cvar to set the module to give the choice to simply notify when someone is spamming commands rather than kicking them just in case people would rather have that than simply having an autokick upon command spam.
Thank you again for the report, I will hopefully be able to update the plugins within this week/weekend and release an updated version. I will respond back to this issue once it has been updated.
Plugin has been updated to 0.8.6.5 with snd_setsoundparam added as a command to be ignored when used (so it does not count as spam when the plugin checks) and the new smac_anticmdspam_kick feature that I mentioned was added and tested in TF2 (since I have a test server setup for testing general purpose stuff).
This issue should be resolved, but feel free to let me know if its not working. Alternatively, you can block this command yourself with the plugins various commands that can add/ignore or remove a command to be listened for/checked for (as stated earlier in this issue). Thanks again for reporting the issue.