Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated To New Syntax #23

Merged
merged 2 commits into from Nov 18, 2019

Conversation

@caxanga334
Copy link
Contributor

caxanga334 commented Nov 16, 2019

  • Updated all plugins to new syntax.
  • Replaced colors with morecolors.

Note: Compiled on SM 1.10

caxanga334 added 2 commits Nov 16, 2019
Replaced some functions with new ones.
@Silenci0

This comment has been minimized.

Copy link
Owner

Silenci0 commented Nov 16, 2019

Oh wow, thank you for this, its really appreciated! I'll be reviewing the changes made, which might take a little bit of time, and I'll get back to you on merging the files into the main repo.

@Silenci0

This comment has been minimized.

Copy link
Owner

Silenci0 commented Nov 18, 2019

Sorry for the wait on this, but after reviewing everything, I'll be merging this request and following it up with another update to the repo as well with some updates of my own shortly after.

As an aside, I'd like to mention that the code in the repo uses soft tabs instead of hard tabs with the soft tabs being 4 spaces == 1 tab. While I did not clearly outline this clearly for the repo (which is my fault for not doing so, I will correct this later with a general guideline), I wanted to mention it here for future updates/releases since it is important for the code to stay consistent.

However, do not take the above as criticism, I simply wanted to mention it for future updates/clarity. The code you've contributed works and is a vast improvement in modernizing SMAC overall, which is both great and very welcome for the project. Excellent work and thank you for your contribution!

@Silenci0 Silenci0 merged commit 9679b37 into Silenci0:master Nov 18, 2019
@caxanga334

This comment has been minimized.

Copy link
Contributor Author

caxanga334 commented Nov 18, 2019

I was getting warning 217: loose indentation a lot when compiling.

@Silenci0

This comment has been minimized.

Copy link
Owner

Silenci0 commented Nov 18, 2019

ah I see, that would explain it.

No worries. In the latest upload, I made sure to double check and retab the code. I did not get any errors or indentation warnings on my end so I think it should be okay now.

Again, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.