Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Gmod support, updating game check to use EngineVersion #27

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@404UNFca
Copy link
Contributor

404UNFca commented Dec 15, 2019

SourceMod hasn't supported Garry's Mod in years, so I removed that gametype altogether. I also removed the folder name check for tf_beta as the old 2010's-era beta TF2 hasn't been playable for years as well. I also updated most of the game checks to use GetEngineVersion();.

As well, I wonder if support for other games could be added, as there are games like the newer Insurgency games, Black Mesa multiplayer, etc that are supported via EngineVersion and could probably use some form of anticheat.

Finally, is cstrike_beta still playable? Is it still a thing? Do we need to still support it?

@404UNFca

This comment has been minimized.

Copy link
Contributor Author

404UNFca commented Dec 15, 2019

Ah, I just read the README for the first time and saw the note about the "unsupported" folder. Didn't know about that, whoops!

@Silenci0

This comment has been minimized.

Copy link
Owner

Silenci0 commented Dec 16, 2019

Hello 404,

Sorry for the late reply, but thank you for your pull request. I looked over it and I'll go ahead and merge the changes.

As far as removing GMod and TF2 beta, that should be okay to do. I don't see a lot of info on cstrike_beta (which I assume is the CS:S beta) and, though I cannot verify it, its most likely not played anymore, so we can go ahead and get rid of that as well. If anyone actually needs it for some reason, it can always be added back.

As far as the other games and their engine version, they are as follows:

Engine_SDK2013 = Game_ZPS, Game_FOF
Engine_SourceSDK2006 = Game_HIDDEN, Game_HL2CTF
Engine_Insurgency = Game_INSMOD

Although INSMOD is supposed to represent the old 2006-2007 mod, I don't think that mod works anymore or has servers since the Steam version came out in 2014, at least from what I've read. Truth be told, the Steam version of insurgency also used the same folder name as the mod, so anyone using SMAC in the 2014 version of Insurgency probably got it to run on their servers, though I don't know how well it worked for that game since that was around the time SMAC kinda fell off the map. However, I think it would be better to swap support for INSMOD from the 2007 mod to the one found on Steam, so I'll probably rename it INS instead to clear up confusion.

As for supporting other Source games, adding support for them should be fine. They would need to be tested as I'm sure there will be some differences that might need accounted for, but other than that, I think it will be okay to support games like Black Mesa Multiplayer and any others that might find it useful (maybe Zombie Master Reborn?). After I merge your changes, I'll add a few more of my own based on the info laid out here and hopefully have something updated before the end of next week.

Thanks again for your contribution.

Silence

@Silenci0 Silenci0 merged commit f537b91 into Silenci0:master Dec 16, 2019
@404UNFca

This comment has been minimized.

Copy link
Contributor Author

404UNFca commented Dec 18, 2019

Gonna take a shot in the dark and guess that you already know to check the EngineVersion + the game folder name for Engine_SourceSDK2006 and Engine_SDK2013 games. I'll continue reading through the plugin at my leisure and fix up whatever else I see that could be fixed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.