New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update various dependencies #452
Conversation
Hmmm.... worked for me locally but failed even on Node.js 12.6.0 (which is what I was using locally) on Travis.... Guess I need to look more closely.... |
Please, correct me if I'm wrong, but it seems to me that travis is breaking because it is set to use some really old node versions:
I'd change
|
It broke on Node.js 12.x on Travis too, although not for me locally. https://travis-ci.org/SimenB/stylint/jobs/557142681 Changing |
This module isn't really maintained. Happy to drop all EOL versions of node and release a major, though |
Lol It doesn't even make sense what I said up there with the log you linked me, I must have seen a log from another place. Sorry for that. I downloaded @Trott repository and can confirm that the tests don't fail for me as well. |
5cd3ff4
to
6c1b6be
Compare
Update dev dependency: * mocha 2.5.3 -> 4.1.0 Update dependency: * chokidar 3.0.1 -> 3.0.2 The mocha udpate requires using `--exit` to preserve the behavior of mocha exiting when the tests are done even if there is something keeping the event loop open. Ideally, someone should go through the tests and do cleanup to figure out what is preventing exit without the `--exit` flag.
Got rid of the unhandled promise rejection warnings (which were caused by calling Used I think this should be passing now. |
Travis is green! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Trott do you want this released? |
I'd appreciate a release! :) If you're referring to a new release on npm, otherwise just ignore me. |
Cool, 2.0.0 published 🙂 |
Update dev dependencies:
Update dependency:
The mocha udpate required a small change to the test file as mocha no
longer forces an exit once all tests have passed. So a file had to be
unwatched after the relevant test passed, or otherwise mocha would not
exit.
These updates resolve all warnings from
npm audit
on a fresh clone of the repository.