Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update various dependencies #452

Merged
merged 2 commits into from Jul 13, 2019
Merged

chore: Update various dependencies #452

merged 2 commits into from Jul 13, 2019

Conversation

Trott
Copy link
Contributor

@Trott Trott commented Jul 11, 2019

Update dev dependencies:

  • istanbul 0.4.3 -> 0.4.5
  • jsdoc 3.4.2 -> 3.6.2
  • mocha 2.5.3 -> 6.1.4

Update dependency:

  • chokidar 1.5.2 -> 3.0.2

The mocha udpate required a small change to the test file as mocha no
longer forces an exit once all tests have passed. So a file had to be
unwatched after the relevant test passed, or otherwise mocha would not
exit.

These updates resolve all warnings from npm audit on a fresh clone of the repository.

@Trott
Copy link
Contributor Author

Trott commented Jul 11, 2019

Hmmm.... worked for me locally but failed even on Node.js 12.6.0 (which is what I was using locally) on Travis.... Guess I need to look more closely....

@ghaschel
Copy link

Please, correct me if I'm wrong, but it seems to me that travis is breaking because it is set to use some really old node versions:

  • 4 - 2015
  • 0.12 - 2015
  • 0.10 - 2013

I'd change travis.yml node_js entry to something like this

  • 6 - 2016
  • 8 - 2017
  • 10 - 2018
  • 12 - 2019

@Trott
Copy link
Contributor Author

Trott commented Jul 11, 2019

Please, correct me if I'm wrong, but it seems to me that travis is breaking because it is set to use some really old node versions:

  • 4 - 2015
  • 0.12 - 2015
  • 0.10 - 2013

I'd change travis.yml node_js entry to something like this

  • 6 - 2016
  • 8 - 2017
  • 10 - 2018
  • 12 - 2019

It broke on Node.js 12.x on Travis too, although not for me locally. https://travis-ci.org/SimenB/stylint/jobs/557142681

Changing .travis.yml would be contingent on the maintainers being OK with dropping support for those older versions.

@SimenB
Copy link
Owner

SimenB commented Jul 11, 2019

This module isn't really maintained. Happy to drop all EOL versions of node and release a major, though

@ghaschel
Copy link

Lol It doesn't even make sense what I said up there with the log you linked me, I must have seen a log from another place. Sorry for that.

I downloaded @Trott repository and can confirm that the tests don't fail for me as well.

@SimenB
Copy link
Owner

SimenB commented Jul 12, 2019

@Trott I merged #451 which updates some of the deps and drops older nodes. Would you be able to investigate the failing CI? It fails the same way for me locally (although it doesn't hang...)

@Trott
Copy link
Contributor Author

Trott commented Jul 12, 2019

@Trott I merged #451 which updates some of the deps and drops older nodes. Would you be able to investigate the failing CI? It fails the same way for me locally (although it doesn't hang...)

Rebased and force-pushed. Still fails, but I'll take a look....

@Trott Trott force-pushed the update-deps branch 2 times, most recently from 5cd3ff4 to 6c1b6be Compare July 12, 2019 16:24
Update dev dependency:

* mocha 2.5.3 -> 4.1.0

Update dependency:

* chokidar 3.0.1 -> 3.0.2

The mocha udpate requires using `--exit` to preserve the behavior of
mocha exiting when the tests are done even if there is something keeping
the event loop open. Ideally, someone should go through the tests and do
cleanup to figure out what is preventing exit without the `--exit` flag.
@Trott
Copy link
Contributor Author

Trott commented Jul 12, 2019

Got rid of the unhandled promise rejection warnings (which were caused by calling chokidar.watch() with an empty or non-string path).

Used --exit with mocha to preserve the mocha 2.x behavior of exiting even when the tests are done even if there's stuff keeping the event loop open.

I think this should be passing now.

@Trott
Copy link
Contributor Author

Trott commented Jul 12, 2019

Travis is green! 🎉

Copy link
Owner

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 97197c9 into SimenB:master Jul 13, 2019
@SimenB
Copy link
Owner

SimenB commented Jul 13, 2019

@Trott do you want this released?

@brwnrclse
Copy link
Contributor

I'd appreciate a release! :) If you're referring to a new release on npm, otherwise just ignore me.

@SimenB
Copy link
Owner

SimenB commented Jul 13, 2019

Cool, 2.0.0 published 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants