From 9d3309e5537dc68eb69a41a7714d38dd183b69c8 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 12 Jul 2019 10:55:10 -0700 Subject: [PATCH 1/2] fix: Provide path in tests so chokidar does not throw --- test/test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test.js b/test/test.js index f2205a2a..954e6b14 100644 --- a/test/test.js +++ b/test/test.js @@ -212,6 +212,7 @@ describe( 'Core Methods: ', function() { beforeEach( function() { app.watcher = undefined + app.state.path = 'fhqwhgads' // Chokidar throws without a path. } ) it( 'should be a function', function() { From b867cd8e987855af5a6d07012893d01b6376316e Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 10 Jul 2019 22:06:43 -0700 Subject: [PATCH 2/2] chore: Update various dependencies Update dev dependency: * mocha 2.5.3 -> 4.1.0 Update dependency: * chokidar 3.0.1 -> 3.0.2 The mocha udpate requires using `--exit` to preserve the behavior of mocha exiting when the tests are done even if there is something keeping the event loop open. Ideally, someone should go through the tests and do cleanup to figure out what is preventing exit without the `--exit` flag. --- package.json | 8 ++++---- test/test.js | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 7aa8f950..4929efb5 100644 --- a/package.json +++ b/package.json @@ -37,7 +37,7 @@ "chai": "3.5.0", "eslint": "2.13.1", "jsdoc": "3.6.2", - "mocha": "2.5.3", + "mocha": "4.1.0", "nyc": "14.1.1", "sinon": "1.17.4", "touch": "1.0.0" @@ -45,7 +45,7 @@ "dependencies": { "async": "1.5.2", "chalk": "1.1.3", - "chokidar": "3.0.1", + "chokidar": "3.0.2", "columnify": "1.5.4", "glob": "7.0.4", "lodash.defaults": "4.2.0", @@ -55,12 +55,12 @@ "yargs": "4.7.1" }, "scripts": { - "cover": "nyc mocha", + "cover": "nyc mocha --exit", "docs": "jsdoc src/ --recurse --destination docs/", "lint": "eslint .", "precover": "npm run lint", "pretest": "npm run lint", "start": "node --harmony index.js", - "test": "mocha" + "test": "mocha --exit" } } diff --git a/test/test.js b/test/test.js index 954e6b14..48571aaa 100644 --- a/test/test.js +++ b/test/test.js @@ -212,7 +212,7 @@ describe( 'Core Methods: ', function() { beforeEach( function() { app.watcher = undefined - app.state.path = 'fhqwhgads' // Chokidar throws without a path. + app.state.path = '.' // Chokidar throws without a path. } ) it( 'should be a function', function() {