From 3e79f09175b32449fec7010421e74735ba77e16d Mon Sep 17 00:00:00 2001 From: Kirk Beitz Date: Sat, 4 May 2019 16:20:21 -0700 Subject: [PATCH] Xcode 10.2: update localization configuration for 0 files opening this project in Xcode 10.2 results in issue navigator diagnostics: - a warning diagnostic that the project needs to be migrated w.r.t. the deprecated usage of "developmentRegion = English" - another diagnostic w.r.t. the use of Base localization however, there are 0 localized files in the project, so it is actually possible to remove the localized "known region" (as seen in the XML diff) to contain no regions. Xcode 10.2.1 does suggest enabling the warning "CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES" in order to capture any cases of broken usage (of which there are none currently). --- PhoneNumberKit.xcodeproj/project.pbxproj | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PhoneNumberKit.xcodeproj/project.pbxproj b/PhoneNumberKit.xcodeproj/project.pbxproj index 0d080f919..ef0644684 100644 --- a/PhoneNumberKit.xcodeproj/project.pbxproj +++ b/PhoneNumberKit.xcodeproj/project.pbxproj @@ -396,10 +396,9 @@ }; buildConfigurationList = 3424185E1BB6E5A000EE70E7 /* Build configuration list for PBXProject "PhoneNumberKit" */; compatibilityVersion = "Xcode 8.0"; - developmentRegion = English; + developmentRegion = en; hasScannedForEncodings = 0; knownRegions = ( - en, ); mainGroup = 3424185A1BB6E5A000EE70E7; productRefGroup = 342418651BB6E5A000EE70E7 /* Products */; @@ -559,6 +558,7 @@ isa = XCBuildConfiguration; buildSettings = { ALWAYS_SEARCH_USER_PATHS = NO; + CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES; CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x"; CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; @@ -620,6 +620,7 @@ isa = XCBuildConfiguration; buildSettings = { ALWAYS_SEARCH_USER_PATHS = NO; + CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES; CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x"; CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES;