Add Where Features #356

SLGShark6 · 2020-02-12T21:34:24Z

Where Expression Changes

I removed the FuncBuilder, and replaced usage with a ExpressionBuilder. Opting to just call compile on the returned Expression wherever a Func is required.

Updated the related Tests to do some additional testing with ExpressionBuilder.

So now for functional additions:

Added the ability to specify a logical operator (Connector) on the where expression, either "and" or "or". The connector must be specified on the preceding where expression.
E.g:

{
    entity(
        where: [
            {path: "content", comparison: contains, value: "4", connector: or},
            {path: "content", comparison: contains, value: "2"}"
        ]
    )
    {
        property
    }
}

To complement the addition of Connectors, I added the ability to now create grouped expressions, by leaving off the other where expression arguments and just specifying a groupedExpressions argument that takes a list of where expressions.
E.g:

{
    entity(
        where: [
            {
                groupedExpressions: [
                    {path: "content", comparison: contains, value: "4", connector: or},
                    {path: "content", comparison: contains, value: "2"}
                ]
            }
        ]
    )
    {
        property
    }
}

You may also specify a connector to be used on a grouped Expression:
E.g:

{
    entity(
        where: [
            {
                groupedExpressions: [
                    {path: "content", comparison: contains, value: "4", connector: or},
                    {path: "content", comparison: contains, value: "2"}
                ],
                connector: and
            },
            {path: "age", comparison: greaterThanOrEqual, value: "31"}
        ]
    )
    {
        property
    }
}

Added a negation argument to where expressions, so that any query generated by a where expression can be negated. With this feature I removed all negative Comparison values like "NotEqual". Grouped Expressions can be negated as well.

E.g.:

{
    entity(
        where: [
            {
                negate: true,
                groupedExpressions: [
                    {path: "content", comparison: contains, value: "4", connector: or},
                    {path: "content", comparison: contains, value: "2"}
                ],
                connector: and
            },
            {path: "age", comparison: greaterThanOrEqual, value: "31", negate: true}
        ]
    )
    {
        property
    }
}

With these feature additions it should be easy to construct complex filter queries.

Ability to query properties of graphs that are part of list graphs

To access properties of list based navigation properties, the property should be encapsulated in bracket notation "[]". This works on connection queries as well.

E.g:

{
    entity(
        where: [
            {path: "employees[content]", comparison: contains, value: "4"}
        ]
    )
    {
        property
    }
}

Or for more complex traversal:

{
    entity(
        where: [
            {path: "employees[company.employees[content]]", comparison: contains, value: "4"}
        ]
    )
    {
        property
    }
}

Ability to query inherited properties on interface type

For example the ability to now query the Count property on IList properties of graphs. Where this is currently not possible

…Connection Fields) using [] notation with the list item property contained in the brackets. Eg. "employees[content]" or "employees[company.employees[content]]"

…ramework

…xpression - Added comparison enum and graph to where expressions for connecting sibling where expressions/ expression groups

…he updated Grouped/And'd/Or'd Where expressions

…o that sibling Predicate Body's can be combined without input parameter incompatability

…h FilterBuilder - ArgumentReader ReadWhere, is now TryReadWheres to feed the returned where expression enumerable directly into FilterBuilder

…built

…y negate the condition presented - Removed all negative comparison types - Did some code cleanup

…ent argument configurations

…rouped expressions, expression negation and expression combination with "And" and "Or"

…tion for IEfGraphQLService<TDbContext>

- Query Collection properties on interface types - Ability to Group Where Expressions - SImplified comparisons, now allowing the user to negate specific expressions - Ability to query singular properties of list graphs - Remove FuncBuilder and instead only using ExpressionBuilder - Update Docs

SimonCropp · 2020-02-15T01:14:43Z

doco/mdsource/query-usage.source.md

 * `startsWith`: Only works with `string`
 * `endsWith`: Only works with `string`
 * `in`: Check if a member existing in a given collection of values
- * `notIn`: Check if a member doesn't exist in a given collection of values


was notin removed?

Yeah it was, removed it since the negate option was added to the where expression.

Bit of a short sighted decision on my part considering this removes backwards compatibility to all the existing user's queries.

I can re-add it.

Re-added the notIn operator and verified it working

SimonCropp · 2020-02-15T01:16:08Z

doco/mdsource/query-usage.source.md


+The above expression written as a logical statement would be:
+
+Property.startsWith("value") && (Property.endsWith("ue") || Property.endsWith("id"))


can u make this a code block

SimonCropp · 2020-02-15T01:17:45Z

src/GraphQL.EntityFramework/PropertyAccess/PropertyCache.cs

+    /// <param name="type">Type to retrieve property from</param>
+    /// <param name="propertyOrFieldName">Name of property or field</param>
+    /// <returns></returns>
+    static MemberInfo GetPropertyOrField(Type type, string propertyOrFieldName)


does this execute on every execution? shouldnt it cache the result?

will look at doing that

So that still uses your cache above in the entry function GetProperty above, the naming is a bit confusing considering the entry is "GetProperty" and this is "GetPropertyOrField", it's a copy and paste of the Microsoft "AggregatePath" function with some slight modifications to navigate the inheritance tree of interface types to find the requested property.

So for example getting the "Count" property of an IList type, you have to navigate to the ICollection type to get access to the "Count" property, just because of the way interface inheritance works in dotnet.

So the PropertyCache works the same as before except now it properly searches the inheritance tree for interface types for property/field info.

SimonCropp · 2020-02-15T01:18:30Z

src/GraphQL.EntityFramework/Where/ArgumentProcessor_List.cs

-                var predicate = FuncBuilder<TItem>.BuildPredicate("Id", Comparison.In, values);
-                items = items.Where(predicate);
+                var predicate = ExpressionBuilder<TItem>.BuildPredicate("Id", Comparison.In, values);
+                items = items.Where(predicate.Compile());


does this run for every execution? if so isnt compile an expensive operation?

So i haven't looked at the project in a while, but my line of thinking was to reduce the code complexity.

I don't remember what it was that caused the divergence for the need to have a FuncBuilder and ExpressionBuilder. I believe the Expression is just the object representation of a function delegate and will have to be compiled anyways to be called wherever it is used.

It would be cheaper to solely use function delegates, rather than expressions.

SimonCropp · 2020-02-15T01:19:21Z

src/GraphQL.EntityFramework/Where/ArgumentReader.cs

-        return getArgument.ReadList<WhereExpression>("where");
+        expression = getArgument.ReadList<WhereExpression>("where");
+
+        if (expression.Count() > 0)


perhaps return expression.Any()?

Spent too much time working on an angular app sorry lol

SimonCropp · 2020-02-15T01:20:03Z

src/GraphQL.EntityFramework/Where/ExpressionBuilder.cs

+        /// <summary>
+        /// Make String List In Comparison
+        /// </summary>
+        /// <param name="values"></param>


can u remove the empty params and returns

SimonCropp · 2020-02-28T23:32:15Z

@SLGShark6 any chance you have time to answer my questions.

SLGShark6 · 2020-03-02T20:42:21Z

sorry about the delay in reply

…g it as deprecated)

…tyFramework into FeaturePR

…tation a code block

…tyFramework into FeaturePR

SLGShark6 · 2020-03-03T21:24:47Z

Getting interesting build error in the appveyor check there, probably related to the maxwidth set in the mdsnippets.json?

SimonCropp · 2020-03-19T04:01:03Z

This is now deployed. NuGet may take some time to make it available for download.

SLGShark6 and others added 24 commits October 3, 2019 10:54

- Added ability to query list based navigation properties (Including …

10eb877

…Connection Fields) using [] notation with the list item property contained in the brackets. Eg. "employees[content]" or "employees[company.employees[content]]"

- Get dbcontext working in sample web

fc6751b

Merge branch 'master' of https://github.com/SLGShark6/GraphQL.EntityF…

f332d5c

…ramework

- Added the ability to group where expressions under a parent where e…

edc7368

…xpression - Added comparison enum and graph to where expressions for connecting sibling where expressions/ expression groups

- Created FilterBuilder Static Generic Class that properly consumes t…

863d1ca

…he updated Grouped/And'd/Or'd Where expressions

- Updated PropertyCache so the Source Paramter is only created once s…

7da0c28

…o that sibling Predicate Body's can be combined without input parameter incompatability

- Removed ExpressionBuilder and FuncBuilder, replacing all usages wit…

5dd706e

…h FilterBuilder - ArgumentReader ReadWhere, is now TryReadWheres to feed the returned where expression enumerable directly into FilterBuilder

- Getting ready to add more operators and change how expressions are …

e745dd1

…built

Merge SimonCropp/GraphQL.EntityFramework:master

29c4d39

Merge branch 'SimonCropp-master'

e814951

- Added a negate parameter to the where expression graph to optionall…

8646300

…y negate the condition presented - Removed all negative comparison types - Did some code cleanup

- Re-added null comparison functionality and fixed null violations

8ffe56e

- Only ignore buildserviceprovider error

d345895

- Rename ExpressionBuilderTests to FilterBuilderTests

f43f7c0

- Added overloaded BuildPredicate Methods to FilterBuilder for differ…

bb5e582

…ent argument configurations

- Updated Tests to use FilterBuilder and test new features, such as g…

b6b15b9

…rouped expressions, expression negation and expression combination with "And" and "Or"

- Added back list navigation query test to Tests Project

83bc832

- Removed reference to external graphql library

e3730e5

- Fixed method docs errors

4742ef6

- Fixed Processlist using wrong property path in filter builder

740f1c9

- Add ability to send the service lifetime in to the service registra…

0045a1c

…tion for IEfGraphQLService<TDbContext>

- Merge origin repo

49d434d

Doco changes

4595f24

SimonCropp reviewed Feb 15, 2020

View reviewed changes

SLGShark6 and others added 8 commits March 3, 2020 15:10

- Re-added the not in comparison value for where expressions, (markin…

395ea19

…g it as deprecated)

Merge branch 'FeaturePR' of https://github.com/SLGShark6/GraphQL.Enti…

255cc6f

…tyFramework into FeaturePR

Doco changes

adcb3bd

- Made code representation of where expression in query usage documen…

983a0fc

…tation a code block

Merge branch 'FeaturePR' of https://github.com/SLGShark6/GraphQL.Enti…

6eaa902

…tyFramework into FeaturePR

Doco changes

57e6c42

- Replace Argument reader count check with list any() check

cdea466

Merge branch 'FeaturePR' of https://github.com/SLGShark6/GraphQL.Enti…

7f9f891

…tyFramework into FeaturePR

Update mdsnippets.json

4c79303

SimonCropp added this to the 9.4.0 milestone Mar 19, 2020

Update mdsnippets.json

cc365ab

SimonCropp merged commit 28cefca into SimonCropp:master Mar 19, 2020


		The above expression written as a logical statement would be:

		Property.startsWith("value") && (Property.endsWith("ue") \|\| Property.endsWith("id"))

Add Where Features #356

Add Where Features #356

Uh oh!

Conversation

SLGShark6 commented Feb 12, 2020

Where Expression Changes

Ability to query properties of graphs that are part of list graphs

Ability to query inherited properties on interface type

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SLGShark6 Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SimonCropp commented Feb 28, 2020

Uh oh!

SLGShark6 commented Mar 2, 2020

Uh oh!

SLGShark6 commented Mar 3, 2020

Uh oh!

SimonCropp commented Mar 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SLGShark6 Mar 3, 2020 •

edited

Loading