Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full upport for "debug link" #99

Closed
Feandil opened this issue Jun 3, 2015 · 3 comments
Closed

Full upport for "debug link" #99

Feandil opened this issue Jun 3, 2015 · 3 comments

Comments

@Feandil
Copy link
Contributor

Feandil commented Jun 3, 2015

#13 added support for some separate debug info support (namely for build-ids only).

It would be great if you also suported "debug link" based separate debug info (as specified in https://sourceware.org/gdb/onlinedocs/gdb/Separate-Debug-Files.html).

I've implemented a proof of concept in Feandil@5582b26
(I'm no C++ coder and this code is horrible, but seems to work on my system)
(I've also not implemented the CRC32 check which is supposed to take place)

@SimonKagstrom
Copy link
Owner

Sounds like a good addition (and something I wasn't really aware existed)!

Looking at the diff, I don't think your patch looks so bad (and kcov isn't that well written everywhere anyway), so feel free to send a pull request. I can add the crc32 check later.

But I think it would be good to have a regression test for this. Looking at the GDB docs, I guess this can be achieved with the two objcopy commands? I can add it to the robot framework suite.

SimonKagstrom pushed a commit that referenced this issue Jun 5, 2015
Debug links is an extension that allows to store the debug symbols
separately from the binary:
https://sourceware.org/gdb/onlinedocs/gdb/Separate-Debug-Files.html
@SimonKagstrom
Copy link
Owner

I've pushed your commit (with some minor changes), and a test case which exercises the code. I'll take a look at the CRC32 check later and close the bug once that's done. Thanks for the patch!

@SimonKagstrom
Copy link
Owner

6aadc16 implements the CRC check, so closing the bug report. Thanks for the patch again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants