Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows, file lookup should be case-sensitive (tiles, pointed-to level) #284

Open
SimonN opened this issue Jan 9, 2018 · 3 comments
Open

Windows, file lookup should be case-sensitive (tiles, pointed-to level) #284

SimonN opened this issue Jan 9, 2018 · 3 comments
Labels

Comments

@SimonN
Copy link
Owner

@SimonN SimonN commented Jan 9, 2018

Lix 0.9.7.

Forestidia found this, after I wontfixed #270: The mass verifier now explicitly seems to say that the checkmark is updated, though it isn't.

verifier.txt:

Result,Replay filename,Level filename,Player,Saved,Required,Skills,Phyus
(OK),replays/test/letsblockandblow-Forestidia-2017-12-05-065956 - Kopie.txt,levels/single/lemforum/lovely/letsblockandblow.txt,Forestidia,19,19,2,388
[...]
Statistics from 1 replays:
1x (OK): replay solves the pointed-to level.
1 checkmarks for player `Forestidia' updated.

But the checkmark does not appear in the level browser, because it's for an incorrect filename. I should be more strict when retrieving pointed-to levels during replay verification.

Original post on Lemmings Forums

@SimonN SimonN added the 4-minor label Jan 9, 2018
@SimonN SimonN changed the title Windows, pointed-to lookup should be case-insensitive Windows, pointed-to lookup should be case-sensitive Jan 9, 2018
@SimonN
Copy link
Owner Author

@SimonN SimonN commented Jan 9, 2018

Once the issue in the OP is fixed, investigate:

If you have a replay with lower case "lovely" and one with upper case "Lovely" the amount of levels is duplicated, since it lists all levels with lower case and with upper case directory name and says then "of 80" instead "of 40".

Loading

@SimonN
Copy link
Owner Author

@SimonN SimonN commented Jan 24, 2018

I believe 0.9.9 (and likely several earlier) ditched the case-sensitivity by mistake when I fixed #114. Reason: I don't build a tree of allowed tile names anymore at level start. Whenever a tile is required, I try to open that filename, and the operating system will handle case sensitivity.

Need to check: On Windows, you specify Hatch.H in a level file when the tile is really called hatch.H. Does the game load the tile with the wrongly-cased name?

Loading

@SimonN
Copy link
Owner Author

@SimonN SimonN commented Jan 24, 2018

From Forestidia on Windows 8:

Yeah it loads as far as I have tested. And yeah it seems to be from 0.9.7 on. But my first trouble with the checkmarks was with an earlier version (I think 0.9.4).

Loading

@SimonN SimonN added 3-bug and removed 4-minor labels Jan 24, 2018
@SimonN SimonN changed the title Windows, pointed-to lookup should be case-sensitive Windows, file lookup should be case-sensitive (tiles, pointed-to level) Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant