Simon Sapin SimonSapin

Organizations

@mozilla @Kozea @servo
SimonSapin commented on pull request servo/servo#5361
@SimonSapin

@mbrubeck Looks good to me in components/style. Was there anything else?

SimonSapin commented on pull request servo/servo#5935
@SimonSapin

components/gfx/font.rs, line 188 [r1] (raw file): The issue above is in the wrong repo. See #5938 instead. Comments from the review on Reviewable.io

@SimonSapin
Uppercase strings rather than chars for small-caps
@SimonSapin
Uppercase strings rather than chars for small-caps
SimonSapin commented on issue rust-lang/rust#25106
@SimonSapin

Oops! Yes, sorry.

SimonSapin commented on issue rust-lang/rust#25106
@SimonSapin

I just realized it’s not as easy as upper-casing entire text nodes, we only want to reduce the font size of things that were previously lower-case.

SimonSapin commented on pull request servo/servo#5935
@SimonSapin

components/gfx/font.rs, line 188 [r1] (raw file): I’ve filed rust-lang/rust#25106 about this. The comment should probably link to it. components/g…

@SimonSapin
Uppercase strings rather than chars for small-caps
SimonSapin commented on issue servo/rust-url#102
@SimonSapin

93bc3d1 should avoid most of these issues.

@SimonSapin
  • @SimonSapin 93bc3d1
    Build most Windows-specific code on non-Windows too so it doesn’t bit…
@SimonSapin
SimonSapin commented on issue servo/rust-url#102
@SimonSapin

@jaxx yes, probably. But the deeper problem is that we have code that I never build or test, so it inevitably breaks.

@SimonSapin
Windows build regularly gets broken
SimonSapin commented on pull request servo/rust-url#101
@SimonSapin

Thanks!

@SimonSapin
SimonSapin merged pull request servo/rust-url#101
@SimonSapin
fix build on Windows
1 commit with 1 addition and 1 deletion
SimonSapin commented on pull request servo/servo#5361
@SimonSapin

components/style/viewport.rs, line 20 [r5] (raw file): Ah, yes, I put this comment in the wrong place, sorry. When we upgrade to a Rust that has it…

SimonSapin commented on pull request servo/servo#5932
@SimonSapin

@bors-servo: retry Unexpected Results ================== /2dcontext/compositing/2d.composite.uncovered.image.destination-atop.html ----------------…

SimonSapin commented on pull request servo/rust-url#100
@SimonSapin

.cargo/config is not the place where you specify features (Cargo.toml of the dependent is). It only specifies where to find source code. Have you t…

SimonSapin commented on pull request servo/rust-url#100
@SimonSapin

Ok, I published version 0.2.32 on crates.io. To override, create a .cargo/config file (e.g. at the root of the servo repository, it’s is .gitignored…

@SimonSapin
SimonSapin commented on issue Kozea/WeasyPrint#250
@SimonSapin

I can’t reproduce this in WeasyPrint master. This test case produces a warning: Failed to load image at file:///i/do/not/exist.png : URLError: <url…

SimonSapin commented on pull request servo/servo#5361
@SimonSapin

Reviewed files: components/style/lib.rs @ r1 components/style/parser.rs @ r1 components/style/selector_matching.rs @ r3 components/style/styleshee…

@SimonSapin
  • @SimonSapin 4959005
    Triggering a new build at 2015-05-04T03:42:03+0000
@SimonSapin
SimonSapin commented on pull request servo/servo#5924
@SimonSapin

Thanks!

SimonSapin merged pull request servo/servo#5924
@SimonSapin
Added mesa-libOSMesa-devel as a dependency for Fedora compilation
1 commit with 1 addition and 1 deletion
SimonSapin commented on pull request seanmonstar/num_cpus#9
@SimonSapin

@seanmonstar, could you publish this on crates.io?

SimonSapin commented on issue Kozea/WeasyPrint#250
@SimonSapin

A test case to reproduce the issue would be good too. Thanks!