fix: Hide unwatched topics from the recent posts pages #6908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the unwatched predicates from LEFT JOINed tables to the WHERE clause to ensure that the value is picked up as intended. Use COALESCE for when the row/value does not exist. Fix SimpleMachines#6907 Signed-off-by: John Rayes <live627@gmail.com>
albertlast
reviewed
Aug 3, 2021
| LEFT JOIN {db_prefix}log_mark_read AS lmr ON (lmr.id_board = t.id_board AND lmr.id_member = {int:current_member}) | ||
| WHERE t.' . $query_this_board . ($context['showing_all_topics'] && !empty($earliest_msg) ? ' | ||
| AND t.id_last_msg > {int:earliest_msg}' : (!$context['showing_all_topics'] && empty($_SESSION['first_login']) ? ' | ||
| AND t.id_last_msg > {int:id_msg_last_visit}' : '')) . ' | ||
| AND COALESCE(lt.id_msg, lmr.id_msg, 0) < t.id_last_msg' . ($modSettings['postmod_active'] ? ' | ||
| AND t.approved = {int:is_approved}' : '') . '', | ||
| AND t.approved = {int:is_approved}' : '') . ' | ||
| AND COALESCE(lt.unwatched, 0) != 1', |
There was a problem hiding this comment.
is COALESCE realy needed here?
it harm the performance of the query here.
There was a problem hiding this comment.
Yes, for the reason outlined in the op/commit message.
Sesquipedalian
approved these changes
Aug 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the unwatched predicates from
LEFT JOINed tables to theWHEREclause to ensure that the value is picked up as intended. UseCOALESCEfor when the row/value does not exist.Fix #6907
Signed-off-by: John Rayes live627@gmail.com