Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alert counts #7510

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Conversation

sbulen
Copy link
Contributor

@sbulen sbulen commented Jun 25, 2022

Three changes:

  • Addressed an issue where alert counter was not getting updated for all subscribers on replies. This is a bug that definitely impacts the alert counter and popup.
  • Used the standard calculation in one instance where the logic looked a little sketchy.
  • Removed an erroneous calc, where it was updating the alert counter with new unread, instead of all unread. Not sure it was necessary there anyway.

Signed by Shawn Bulen, bulens@pacbell.net
@sbulen sbulen added this to the 2.1.3 milestone Jun 25, 2022
sbulen added 2 commits June 25, 2022 06:21
Signed by Shawn Bulen, bulens@pacbell.net
Signed by Shawn Bulen, bulens@pacbell.net
@sbulen sbulen force-pushed the fix_alert_counts branch from a5fe9d6 to 394cc0c Compare June 25, 2022 13:42
@sbulen
Copy link
Contributor Author

sbulen commented Jun 26, 2022

I've been running this on my site the last couple of days. Alerts are delivered much more consistently now.

Also, I periodically audit the alert counter, and it is now perfectly aligned with the alerts, and does not fall out of sync anymore.

sbulen added 2 commits July 21, 2022 19:01
Signed by Shawn Bulen, bulens@pacbell.net
Signed by Shawn Bulen, bulens@pacbell.net
@Sesquipedalian Sesquipedalian merged commit 06cdc6c into SimpleMachines:release-2.1 Aug 16, 2022
@pr-triage pr-triage bot added the PR: merged label Aug 16, 2022
@sbulen sbulen deleted the fix_alert_counts branch October 4, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants