PHP 8 email line break change #7560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed by Shawn Bulen, bulens@pacbell.net
Signed by Shawn Bulen, bulens@pacbel.net
|
Opted for a slightly safer solution that only tweaked the behavior for 8x. 7x is left as-is. Although my tests in 7x were OK, it's possible that some other environments really won't like the crlf going to mail(). E.g., in the php bug report above, some users complained that crlf was translated to crcrlf in their systems, since their envs were performing a lf => crlf conversion, resulting in broken headers... Best to play it safe... |
BrickOzp
approved these changes
Oct 13, 2022
|
Thanks, @BrickOzp ! |
smusmanobjects
added a commit
to wpexpertsio/Post-SMTP
that referenced
this pull request
Mar 2, 2023
In some PHP 8.0.x, issues with \r\n * php/php-src#8086 * SimpleMachines/SMF#7560 * https://www.drupal.org/project/drupal/issues/3270647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emails were not getting sent properly due to malformed headers under the following circumstances:
Due to a change in PHP 8, the PHP mail() function now expects line endings to be "\r\n", even on linux systems. The old SMF logic that changed the line endings per the OS was actually breaking things when using the mail type of PHP on linux.
This fix has been tested on all variants of PHP7.4 vs PHP8.1, windows vs linux, PHP vs SMTP.
See forum discussion:
https://www.simplemachines.org/community/index.php?topic=583842.0
See PHP 8 bug report & discussion. Note the bug report was closed w/o action, saying the new behavior is in line with the RFC:
php/php-src#8086