New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie will be not destroy when the board move to subfolder #4366

Closed
albertlast opened this Issue Oct 20, 2017 · 8 comments

Comments

Projects
None yet
5 participants
@albertlast
Collaborator

albertlast commented Oct 20, 2017

When you got local cookie and change the board from exp. /smf to /smf/test
the cookie get lost smf is not able to delete/destroy the cookie
This issue is reintroduce by #4363

@sbulen

This comment has been minimized.

Show comment
Hide comment
@sbulen

sbulen Oct 20, 2017

Contributor

This is a dupe of #4297

Contributor

sbulen commented Oct 20, 2017

This is a dupe of #4297

@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Oct 20, 2017

Collaborator
Collaborator

albertlast commented Oct 20, 2017

@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Oct 21, 2017

Collaborator

i checked the pr from sbulen and he didn't fix the issue.

Collaborator

albertlast commented Oct 21, 2017

i checked the pr from sbulen and he didn't fix the issue.

@sbulen

This comment has been minimized.

Show comment
Hide comment
@sbulen

sbulen Oct 24, 2017

Contributor

Note a correction: this issue is not a dupe of #4297.

Contributor

sbulen commented Oct 24, 2017

Note a correction: this issue is not a dupe of #4297.

@jdarwood007

This comment has been minimized.

Show comment
Hide comment
@jdarwood007

jdarwood007 Oct 24, 2017

Member

By board you mean forum I assume?

Member

jdarwood007 commented Oct 24, 2017

By board you mean forum I assume?

@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Oct 24, 2017

Collaborator

Sure,
Like i already mention,
the issue for this is the missing information of the path from the cookie (which was already fixed in my pr)

Collaborator

albertlast commented Oct 24, 2017

Sure,
Like i already mention,
the issue for this is the missing information of the path from the cookie (which was already fixed in my pr)

@sbulen

This comment has been minimized.

Show comment
Hide comment
@sbulen

sbulen Oct 29, 2017

Contributor

My problem with this issue is that I think it ends up defeating the purpose of the localCookie setting.

Local cookies are intended to allow support for different forums in different subfolders. I.e., each forum is in a unique subfolder and there is a corresponding cookie. If you make cookie behavior independent of the subfolder, you have essentially disabled localCookies, i.e., they are now global.

The online help indicates that keeping the subfolders distinct is important for some ISPs that are organized in that way. You do not want the forum software or cookie operating outside of its scope.

If you DO want it to use the cookie for the whole structure, independent of the subfolders, then you should de-select Local Cookies.

Contributor

sbulen commented Oct 29, 2017

My problem with this issue is that I think it ends up defeating the purpose of the localCookie setting.

Local cookies are intended to allow support for different forums in different subfolders. I.e., each forum is in a unique subfolder and there is a corresponding cookie. If you make cookie behavior independent of the subfolder, you have essentially disabled localCookies, i.e., they are now global.

The online help indicates that keeping the subfolders distinct is important for some ISPs that are organized in that way. You do not want the forum software or cookie operating outside of its scope.

If you DO want it to use the cookie for the whole structure, independent of the subfolders, then you should de-select Local Cookies.

@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Oct 30, 2017

Collaborator

The behavior of the localcookies didn't change,
so your comment make no sense.

Collaborator

albertlast commented Oct 30, 2017

The behavior of the localcookies didn't change,
so your comment make no sense.

@Gwenwyfar Gwenwyfar added the Cookies label Dec 9, 2017

@albertlast albertlast referenced this issue Jan 12, 2018

Merged

Cookie #4481

Sesquipedalian added a commit to Sesquipedalian/SMF2.1 that referenced this issue Jan 12, 2018

Fixes SimpleMachines#4366
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment