New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gender Icon profile fields Multilanguage Bug #4381

Closed
wintstar opened this Issue Nov 4, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@wintstar

wintstar commented Nov 4, 2017

The Gender icon Status ist not display in other language. As an example in German.

The bug is in INPUT.
generic_icons gender_{INPUT}
Input is the replacement for None, Male or Female. But when it is translated in the admin center => Custom profile fields, it results to keine Angabe, Männlich oder Weiblich.

gender_german-1

gender_german-2

gender_german-3
gender_german-4

gender_german-5

Possible solution would be to change the value in index. css. But I find it to be a less than optimal solution.

=> http://www.stephan-frank.de/board/index.php/topic,12.msg24.html#msg24

@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Nov 5, 2017

Collaborator

Like already mention from you,
you need two information:

  • the orginal db value (male,femal, etc) for technical stuff like css class
  • the translatet db value for displaying

So in my eyes the main issue is the missing translation function of customfields like here the gender.

Beside of {INPUT} which return the database value,
which you need in your css class (in english) you need somethinkg like {DISPLAY_INPUT} (maybe another name would be better),
which show the translation of this database value.
input "male" get than "Männlich" this information would be solve the key issue here i believe.

Maybe @Gwenwyfar could at some ideas

Collaborator

albertlast commented Nov 5, 2017

Like already mention from you,
you need two information:

  • the orginal db value (male,femal, etc) for technical stuff like css class
  • the translatet db value for displaying

So in my eyes the main issue is the missing translation function of customfields like here the gender.

Beside of {INPUT} which return the database value,
which you need in your css class (in english) you need somethinkg like {DISPLAY_INPUT} (maybe another name would be better),
which show the translation of this database value.
input "male" get than "Männlich" this information would be solve the key issue here i believe.

Maybe @Gwenwyfar could at some ideas

@wintstar

This comment has been minimized.

Show comment
Hide comment
@wintstar

wintstar Nov 6, 2017

Fix #4383 works. Good solution @MissAllSunday .

wintstar commented Nov 6, 2017

Fix #4383 works. Good solution @MissAllSunday .

@wintstar wintstar closed this Nov 6, 2017

@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Nov 6, 2017

Collaborator

please close issue only when the pr is merged (mostly they get closed)

Collaborator

albertlast commented Nov 6, 2017

please close issue only when the pr is merged (mostly they get closed)

@wintstar wintstar reopened this Nov 6, 2017

@wintstar

This comment has been minimized.

Show comment
Hide comment
@wintstar

wintstar Nov 6, 2017

Ok, I didn't know.

wintstar commented Nov 6, 2017

Ok, I didn't know.

@PortaMx

This comment has been minimized.

Show comment
Hide comment
@PortaMx

PortaMx Nov 17, 2017

Contributor

I don't understand the complicated way they SMF go for this.
Why not simple put the gender (as smallint) in the members table (default 0)?
So you need not the join over other tables for all basic memberdata.

Contributor

PortaMx commented Nov 17, 2017

I don't understand the complicated way they SMF go for this.
Why not simple put the gender (as smallint) in the members table (default 0)?
So you need not the join over other tables for all basic memberdata.

@Gwenwyfar

This comment has been minimized.

Show comment
Hide comment
@Gwenwyfar

Gwenwyfar Nov 20, 2017

Collaborator

If I understand it correctly, this field was changed to be a custom field, and therefore removed from the basic user data table.

Collaborator

Gwenwyfar commented Nov 20, 2017

If I understand it correctly, this field was changed to be a custom field, and therefore removed from the basic user data table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment