New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - fulltext not allowed if db not myisam #4387

Closed
sbulen opened this Issue Nov 10, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@sbulen
Contributor

sbulen commented Nov 10, 2017

On a newly installed 2.1 forum, pulled up the Search Method form, and received the following prompt:
image

Since it was a new install, the tables were innodb, and this failed the old 2.0 edit that required myisam.

I do think InnoDB supports fulltext these days, mysql 5.6+. I do not know if it is syntactically identical with myisam.

So... I think we need some experimentation to determine whether to remove the myisam restriction, or modify it somehow, to make it smarter based on the version of mysql.

@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Nov 10, 2017

Collaborator

Duplicate to #1571
i got no motivation to look into.

Collaborator

albertlast commented Nov 10, 2017

Duplicate to #1571
i got no motivation to look into.

@illori

This comment has been minimized.

Show comment
Hide comment
@illori

illori Nov 12, 2017

Contributor

we are recommending users to create a custom index, might it be easier to only leave that option along with no index?

Contributor

illori commented Nov 12, 2017

we are recommending users to create a custom index, might it be easier to only leave that option along with no index?

@Oldiesmann

This comment has been minimized.

Show comment
Hide comment
@Oldiesmann

Oldiesmann Nov 12, 2017

Member

While the custom index is recommended, I don't see why we can't support it on InnoDB as well, as long as it doesn't require any major changes.

Other than that we should probably hide the fulltext option if it's not supported.

Member

Oldiesmann commented Nov 12, 2017

While the custom index is recommended, I don't see why we can't support it on InnoDB as well, as long as it doesn't require any major changes.

Other than that we should probably hide the fulltext option if it's not supported.

@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Nov 13, 2017

Collaborator

Why not raised the min mysql version to 5.6(and the compareable mariadb version) -> problem solve.

Collaborator

albertlast commented Nov 13, 2017

Why not raised the min mysql version to 5.6(and the compareable mariadb version) -> problem solve.

@Oldiesmann

This comment has been minimized.

Show comment
Hide comment
@Oldiesmann

Oldiesmann Nov 13, 2017

Member

It doesn't really offer any benefit, and 5.5 is still widely used. It shouldn't be too hard to make sure we're checking the MySQL/MariaDB version before displaying that message.

Member

Oldiesmann commented Nov 13, 2017

It doesn't really offer any benefit, and 5.5 is still widely used. It shouldn't be too hard to make sure we're checking the MySQL/MariaDB version before displaying that message.

@sbulen

This comment has been minimized.

Show comment
Hide comment
@sbulen

sbulen Nov 18, 2017

Contributor

Looks like there was work to enhance the checks here a while back. There is a minor problem with checking the version for innodb. Wrapping up testing & will submit PR shortly.

Contributor

sbulen commented Nov 18, 2017

Looks like there was work to enhance the checks here a while back. There is a minor problem with checking the version for innodb. Wrapping up testing & will submit PR shortly.

@jdarwood007

This comment has been minimized.

Show comment
Hide comment
@jdarwood007

jdarwood007 Nov 19, 2017

Member

We should be getting the db type information now. I remember extending that for the stat collection data.

Member

jdarwood007 commented Nov 19, 2017

We should be getting the db type information now. I remember extending that for the stat collection data.

colinschoen added a commit that referenced this issue Dec 7, 2017

Fulltext search edit - fixes #4387 (#4388)
* Fix innodb fulltext version check
Signed by Shawn Bulen, bulens@pacbell.net

* Clarify fulltext message
Signed by Shawn Bulen, bulens@pacbell.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment