New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar #5030

Closed
smfbigguy opened this Issue Oct 2, 2018 · 23 comments

Comments

Projects
None yet
5 participants
@smfbigguy

smfbigguy commented Oct 2, 2018

As per this post, the calendar is throwing errors caused by spiders:
https://www.simplemachines.org/community/index.php?topic=562437.msg3990510#msg3990510

Steps to reproduce

  1. Enable calendar
  2. Give spiders enough permissions to see calendar
  3. This will produce the errors in the post from SMF

Environment (complete as necessary)

  • Version/Git revision:
  • Database Type: mariadb (from what phpmyadmin says)
  • Database Version: 10.2.18
  • PHP Version: 5.6

Additional information/references

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 2, 2018

Pretty sure I did all that right.

@albertlast

This comment has been minimized.

Collaborator

albertlast commented Oct 2, 2018

Well I mention the issue already here: #4886 (comment)
but this issue got not reopen...

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 2, 2018

It's reopened now. :)

@Sesquipedalian

This comment has been minimized.

Member

Sesquipedalian commented Oct 25, 2018

I am trying to find a way to reproduce this, but I haven't been able to. Are you still seeing these errors, @smfbigguy? If so, can you give me fuller information and more exact instructions on how I can reproduce it?

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 25, 2018

I had turned off permissions for spiders to see the memberlist. That took care of the error. I turned it back on just now so I will post the first error that comes up.

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 25, 2018

All I can do is give ya this. I still get the errors but they are from guests as well as google. It's just people trying to see stuff they can't I would imagine and being asked to login. That's all the info I have.
bt
firefox_screenshot_2018-10-25t22-23-54 698z

@Sesquipedalian

This comment has been minimized.

Member

Sesquipedalian commented Oct 25, 2018

Could you please go to ?action=admin;area=reports;rt=group_perms;st=print and grab a screenshot of that? Hopefully that will help me figure out how to configure the permissions on my test forum in order to be able to reproduce the errors.

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 25, 2018

Yup, here ya go

firefox_screenshot_2018-10-25t23-31-16 314z

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 25, 2018

Battle is not installed anymore and neither is articles. There is a spot in Ehportal for articles but I don't use it.

@jdarwood007

This comment has been minimized.

Member

jdarwood007 commented Oct 26, 2018

From what I can tell in the back trace, it seems this is being triggered when a guest hits the post page.

@Sesquipedalian

This comment has been minimized.

Member

Sesquipedalian commented Oct 26, 2018

Yup, here ya go

Thanks. I'm getting on a plane tomorrow for a few days of travel, but I'll look forward to working on this more next week. Hopefully this info will help me to reproduce the error when I do.

From what I can tell in the back trace, it seems this is being triggered when a guest hits the post page.

Which is weird. I haven't been able to reproduce it, not even when I fake my user agent to impersonate the GoogleBot spider.

@SychO9

This comment has been minimized.

Contributor

SychO9 commented Oct 26, 2018

When I visit @smfbigguy 's forum as a guest and try to access the calendar, the login_cookie_times is undefined, which has been fixed in #4886
I don't think there is anything to fix here, his forum setup just isn't up to date with the latest changes
look for yourself, you can't reproduce it, because there's nothing to reproduce
https://www.whatsurbeef.net/index.php?action=calendar

melocal
My Local setup

whatsurbeef
His forum

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 26, 2018

That may be true. I will update today when I get home from work. I don't have time to do it this morning. It has been a week or to since an update to the site.

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 26, 2018

Your screenshot looks different than mine for some reason.

firefox_screenshot_2018-10-26t12-01-06 640z

@SychO9

This comment has been minimized.

Contributor

SychO9 commented Oct 26, 2018

That's because I'm not opening the login box, I'm accessing the calendar as a guest

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 26, 2018

Oh ok. :)

@jdarwood007

This comment has been minimized.

Member

jdarwood007 commented Oct 26, 2018

Did updating the git checkout resolve it?

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 26, 2018

I am going to update tonight. Just got home from work.

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 27, 2018

I have completed an update right from GH. I just got finished. Well, installing mods now.

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 27, 2018

I have had over 60 people on the forums so far since my last post and no errors...for this issue. I started a new topic on SMF about something else. We figured it out but not sure if it's a bug. I won't go into that here though.

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 27, 2018

I think this can be closed.

@Sesquipedalian

This comment has been minimized.

Member

Sesquipedalian commented Oct 29, 2018

Great. Thanks for testing, @smfbigguy. If the problematic behavous reappears, we can reopen this.

@smfbigguy

This comment has been minimized.

smfbigguy commented Oct 29, 2018

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment