New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrader - Messages say individual steps are complete, when they're not... #5040

Closed
sbulen opened this Issue Oct 10, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@sbulen
Contributor

sbulen commented Oct 10, 2018

Description

I just started the database updates step, but it says it's done. That message is supposed to be displayed upon completion, not during the step:
image

Steps to reproduce

  1. Run a 2.0 to 2.1 update

Environment (complete as necessary)

  • Version/Git revision: 10/9/18
  • Database Type: MySQL
  • Database Version: 5.7
  • PHP Version: 5.6

Additional information/references

Message can be safely ignored.
I did select the option for a new settings.php file, but I don't think it would make a difference here.

@sbulen sbulen changed the title from Upgrader - Message says database update complete, when they're not... to Upgrader - Message says database updates complete, when they're not... Oct 10, 2018

@sbulen

This comment has been minimized.

Show comment
Hide comment
@sbulen

sbulen Oct 10, 2018

Contributor

It also says the UTF8 Conversion is completed, while it is still in progress:
image

Contributor

sbulen commented Oct 10, 2018

It also says the UTF8 Conversion is completed, while it is still in progress:
image

@sbulen

This comment has been minimized.

Show comment
Hide comment
@sbulen

sbulen Oct 10, 2018

Contributor

It also says the JSON step is complete, while it is still in progress... I think I see a pattern here...
image

Contributor

sbulen commented Oct 10, 2018

It also says the JSON step is complete, while it is still in progress... I think I see a pattern here...
image

@sbulen sbulen changed the title from Upgrader - Message says database updates complete, when they're not... to Upgrader - Message says individual steps are complete, when they're not... Oct 10, 2018

@sbulen sbulen changed the title from Upgrader - Message says individual steps are complete, when they're not... to Upgrader - Messages say individual steps are complete, when they're not... Oct 10, 2018

@sbulen

This comment has been minimized.

Show comment
Hide comment
@sbulen

sbulen Oct 10, 2018

Contributor

All the above happens both on WAMP and on Linux hosted.

Contributor

sbulen commented Oct 10, 2018

All the above happens both on WAMP and on Linux hosted.

@jdarwood007

This comment has been minimized.

Show comment
Hide comment
@jdarwood007

jdarwood007 Oct 10, 2018

Member

This is most likely related to #5036 as it is just not hiding that box properly after completing the tasks

Member

jdarwood007 commented Oct 10, 2018

This is most likely related to #5036 as it is just not hiding that box properly after completing the tasks

@sbulen

This comment has been minimized.

Show comment
Hide comment
@sbulen

sbulen Oct 10, 2018

Contributor

To be clear: it is not hiding that message BEFORE completing the task. It should "appear" when the task is complete.

Contributor

sbulen commented Oct 10, 2018

To be clear: it is not hiding that message BEFORE completing the task. It should "appear" when the task is complete.

@Sesquipedalian Sesquipedalian added this to the RC2 milestone Oct 10, 2018

SychO9 added a commit to SychO9/SMF2.1 that referenced this issue Oct 11, 2018

Fix typo in upgrader
fixes SimpleMachines#5040
Signed-off-by: SychO <sychocouldy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment