New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something about legacy BBC (yes again) #5063

Open
live627 opened this Issue Oct 16, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@live627
Contributor

live627 commented Oct 16, 2018

Hum, so this keeps cropping up like those weeds in the yard.

What is the desired effect of their usage? Because, according to my unit tests, most still do work.

untitled2

Reproduction message text

[br][tt]blah[/tt]
[flash]blah[/flash]
[bdo=rtl]blah[/bdo]
[black]blah[/black]
[white]blah[/white]
[red]blah[/red]
[green]blah[/green]
[blue]blah[/blue]
[acronym]blah[/acronym]
[ftp]blah[/ftp]
[glow]blah[/glow]
[move]blah[/move]
[shadow]blah[/shadow]

preparsecode() also still messes with the raw color tags.

@jdarwood007

This comment has been minimized.

Member

jdarwood007 commented Oct 16, 2018

Legacy bbc is supposed to disable the specific bbc code by telling the bbc handler to just do nothing but output the text.

i.e.

[red]test text[/red]

Becomes this on output:

test text

The bbc itself is not displayed. Preventing it from ruining the flow of text, but also preventing it from doing the functionality it did.

This way if a mod author wants to implant it again, they can and just remove it from the legacy bbc array. They can do so by simply calling the bbc hook, then unsetting the legacy they want to implant from the array.

@live627

This comment has been minimized.

Contributor

live627 commented Oct 17, 2018

@Sesquipedalian this should be marked for RC2 as it's not a showstopper.

Should the legacy codes list be defined in parse_bbc? Currently it's in reloadSettings()... I don't see why? Something that I'm not getting?

@jdarwood007

This comment has been minimized.

Member

jdarwood007 commented Oct 17, 2018

Don't think it maters where it is defined as long as its done once and before any work in parse_bbc is done.

@jdarwood007 jdarwood007 added this to the RC2 milestone Oct 17, 2018

@jdarwood007 jdarwood007 added the BBC label Oct 17, 2018

@MissAllSunday

This comment has been minimized.

Contributor

MissAllSunday commented Oct 20, 2018

It was placed on reloadSettings() for the same reason all the other new $context vars were placed on it, to keep a single place where this kind of vars are defined and let a single hook to handle them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment