Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Possible issue in file cache backend #5083
There's always been some concern about the reliability of the file cache backend. I think we have a case where it actively has been shown to break.
If the cached content contains a null byte, the addcslashes call to write the data will truncate the string.
Steps to reproduce
Environment (complete as necessary)
See https://www.simplemachines.org/community/index.php?topic=560471.0 for more including a dump of a modSettings cache entry at 20489 bytes, so not a file write boundary issue (like we saw back in the day). I don't know for sure if this is the problem but it's a reasonable bet right now.