Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Boardindex & Messageindex templates Consistency #5148
Looking at the Boardindex template and the Messageindex template, you can see that the code outputting the boards list is different.
The first organizes code in functions whereas the second just outputs, perhaps we should group the whole code into a function that outputs the list, load Boardindex template in Messageindex source file and use the same function in its template.
If there are no objections I'll make a PR
I didn't think of implanting support for it in MessageIndex. But the BoardIndex template was changed to handle things like redirect boards better. It also made it so things like SimpleDesk or portals could inject fake boards or other stuff to change parts of the displays without needing to hack up the templates.
Yes that's better indeed, I was just thinking it'd be better to have the codes be the same in both templates, and I thought I could just load the board index template and use the same functions instead of redeclaring them, but I can't so I'm just gonna redeclare them.