Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Image proxy - drops images, fsocket/curl restrictions #5172
I just picked 21 random http: images from my forum. With the proxy off, all 21 show. In 2.0, with the proxy ON, 19 show & 2 are dropped. But in 2.1, with the proxy ON, 14 show & 7 are dropped... I see at least 4 different symptoms on the 7 items dropped. ("dropped" means not displayed at all.) I've confirmed this on WAMP & on Linux.
This one is odd, host headers are strange...
This image is not properly cached or displayed in 2.0.15 nor in 2.1.
Steps to reproduce
Environment (complete as necessary)
Tested and it is sending a proper 301, but does send it in a weird way in which I wonder if the library is misdirecting the hostname.
A wget shows it properly redirecting.
Everything looks good on my local WAMP server & matches the above.
My linux server is hosted thru a different provider & has zero luck with that photo. The sockets attempt fails on a connection refused. (This photo only....)
My suspicion is that my host is blacklisted by the provider for that site for fsockets & curl. I've seen similar things before, with different hosts. Usually just a temporary issue until they sort it out.
Image links in posts work, but the image proxy won't work under these circumstances for those photos. So you enable the proxy & the images disappear.
The solution is pretty simple, actually - to treat it the same way we treat files that are too large to cache, just do the redirect.
referenced a pull request that will
Nov 27, 2018
Here's another image with similar behavior. This one fails on both my WAMP & linux servers:
Notes on the above: