New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade.php hardcoded error text #5273

Closed
wintstar opened this Issue Dec 25, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@wintstar
Copy link

wintstar commented Dec 25, 2018

Description

Error text message are hardcoded and cannot be translated

Example

return throw_error('Cannot find ' . $sourcedir . '/Subs-Db-' . $db_type . '.php' . '. Please check you have uploaded all source files and have the correct paths set.');

Environment (complete as necessary)

  • Version/Git revision: Pull Request 5620
  • Database Type: MySQL
  • Database Version: 5.6.42-log
  • PHP Version: 7.1.22

It would be advantageous if the texts could be translated.

@jdarwood007

This comment has been minimized.

Copy link
Member

jdarwood007 commented Dec 28, 2018

Some strings such as these are not easily possible for us to remove the hard coded text, due to this being so early in the startup process and needing to ensure if it looks like not all parts of the code base are there, to bail out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment