Searching in SMF Admin gives error in log #5558
Comments
|
Which fulltext search you use? Did you rebuild it after upgrade? |
|
I also have same error, I'm using "None". |
|
it's just the version number in the search api files hasn't been changed from RC1 to RC2 |
|
Class-CacheAPI got some rc1 too: SMF2.1/Sources/Class-CacheAPI.php Lines 168 to 173 in bce556a SearchAPI: SMF2.1/Sources/Class-SearchAPI.php Lines 148 to 153 in bce556a |
|
Apologies for my loud text in the above report, It was a simple copy and paste, not idea why it did that. Thanks for finding the cause of the error. |
|
I find myself wondering why we even have those minimum version checks for the search and cache APIs. |
|
I guess for mods, The problem when you want realy to do this, |
it is just more locations to forget to update when we do releases and patches. if they are not necessary i think it would good to remove them, or document somewhere that they do exist so we dont forget to update them in the future. |
|
Class-SearchAPI.php will be updated for RC2 or do we have to wait for RC3? |
The previous way required us to update the $verion_compatible string in Class-SearchAPI.php with every release, in a misguided and ineffective attempt to future-proof against API changes. Fixes SimpleMachines#5558 Signed-off-by: Jon Stovell <jonstovell@gmail.com>
|
Okay, I've had a chance to look at the relevant code, and my conclusion is that we should just set Performing a min/max version compatibility check is not completely useless, because (1) one day we may need to check for SMF 2.1 vs. SMF 3.0 versions of the search and cache APIs, and (2) third party plugins might need to declare min/max version compatibility ranges for different versions of said plugins. But since our own included plugins and the API itself can and should remain consistent across all versions of 2.1.x, setting the min/max version compatibility range to reflect that is the only move that makes any sense. |
It'll be fixed in RC3. In the meantime, you can manually edit Class-SearchAPI.php to make the change shown in #5559. |
RC2
Searching in SMF Admin gives me a error in log, but the search still works.
Type of error: Critical
The selected search API the forum is using is out of date - falling back to standard search. Please check file SearchAPI-Standard.php. http://localhost/testrc2/index.php?action=admin;area=search
The text was updated successfully, but these errors were encountered: