Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Should we have a scheduled task for pruning log_topics? #5657

Open
sbulen opened this issue May 6, 2019 · 6 comments

Comments

Projects
None yet
5 participants
@sbulen
Copy link
Contributor

commented May 6, 2019

Description

Question: Should we have a scheduled task for pruning log_topics?

I believe 2.1 has the same behavior as 2.0, in that, log_topics can grow out of hand. In 2.0, we have a script that is shared (informally, in a post) to clean that up.

Additional information/references

https://www.simplemachines.org/community/index.php?topic=212330.msg1667071#msg1667071

@MissAllSunday

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Sure, I'll be in favor of it. Seems simple enough to be incorporated.

@Sesquipedalian

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Makes sense to me.

@live627

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@sbulen

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

I wasn't aware of this... I was trying to make a fresh copy of my DB for testing, but had issues, in part, because this table had millions of rows in it...

@jdarwood007

This comment has been minimized.

Copy link
Member

commented May 10, 2019

To be honest, if this is going to become a scheduled task I recommend:

  1. It be disabled by default for upgrades, new installs can have it installed.
  2. Run on a 15 minute schedule
  3. Limit how many it tries to cleanup at a time.

Large forums could be killed otherwise if this isn't done with millions of entries.

@sbulen

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Agreed. I'd go a step further & say that folks should have to specifically enable it for upgrades & installs. It should not "just run". But I do think it's important to have as an option.

Though I do have a suspicion that most very large forums already know about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.