Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css generic control on menues #5665

Closed
SychO9 opened this issue May 10, 2019 · 1 comment
Closed

css generic control on menues #5665

SychO9 opened this issue May 10, 2019 · 1 comment
Labels
Milestone

Comments

@SychO9
Copy link
Contributor

SychO9 commented May 10, 2019

Description

parts like these should not be targeting a specific menu, instead we can generically target menues without having to edit the CSS for any additional menues, I've already done this in my test environment, it cleans up a lot of the code while still achieving its purpose.

#main_menu .popup_heading, #genericmenu .popup_heading {...}
#main_menu .popup_window, #genericmenu .popup_window {...}
#main_menu .popup_container, #genericmenu > .popup_container {...}
@media (max-width: 480px) 
#main_menu .popup_container, #genericmenu .popup_container {...}
@media (max-width: 480px)
.popup_window, #main_menu .popup_window, #genericmenu .popup_window {...}
@media (max-width: 480px)
#main_menu .popup_heading, #genericmenu .popup_heading {...}

but gotta wait for other theme related PRs to be merged before doing this. it gets messy when there are too many PRs editing the same file

@Sesquipedalian Sesquipedalian added this to the Final milestone May 28, 2019
@sbulen sbulen added the Theme label May 31, 2019
@DiegoAndresCortes
Copy link
Contributor

Dunno if it has been addressed but #main_menu .popup_container, #genericmenu > .popup_container
Needs a higher z-index than the sc editor.
e.g. z-index: 4;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants