add a simple autoloader #3792

Merged
merged 2 commits into from Jan 5, 2017

Projects

None yet

2 participants

@live627
Contributor
live627 commented Jan 4, 2017

fix #3767

Also update minify to v1.3.42

@live627 live627 add a simple autoloader
fix #3767

Also update minify to v1.3.42

Signed-off-by: John Rayes <live627@gmail.com>
e494fd7
@live627 live627 added the Enhancement label Jan 4, 2017
@live627 live627 added this to the Beta 4 milestone Jan 4, 2017
@live627 live627 requested a review from colinschoen Jan 4, 2017
@colinschoen
colinschoen approved these changes Jan 4, 2017 edited View changes

NB: Reviewed only changes to index.php. Didn't review upgrade to minify.

Only nit is to separate this into 2 PRs.

Really happy to see this go in. Custom autoloader LGTM. Happy to think of the potential with mod authors being able to hook into it too. :)

LGTM, approval

index.php
+ );
+
+ // Do any third-party scripts want in on the fun?
+ call_integration_hook('integrate_autoload', $classMap);
@colinschoen
colinschoen Jan 4, 2017 edited Member

Should this be call_integration_hook('integrate_autoload', array(&$classMap));?

@live627 live627 Update index.php
b9fe4b7
@live627 live627 merged commit 42c11ab into SimpleMachines:release-2.1 Jan 5, 2017

2 checks passed

Scrutinizer 2 new issues, 4 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@live627 live627 modified the milestone: Beta 4, Beta 3 Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment