Image proxy should serve images even if they aren't cached #3798

Merged
merged 1 commit into from Jan 5, 2017

Projects

None yet

3 participants

@live627
Contributor
live627 commented Jan 5, 2017

No description provided.

@live627 live627 Image proxy should serve images even if they aren't cached
fix #3781

Signed-off-by: John Rayes <live627@gmail.com>
bd6f4ae
@live627 live627 added the Serious Bug label Jan 5, 2017
@live627 live627 added this to the Beta 4 milestone Jan 5, 2017
@live627 live627 requested a review from colinschoen Jan 5, 2017
@colinschoen

LGTM, approval.

Side note: This would be a good class to use the new autoloader functionality to load require_once($sourcedir . '/Class-CurlFetchWeb.php');

@colinschoen colinschoen merged commit 6acdeb0 into SimpleMachines:release-2.1 Jan 5, 2017

2 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jdarwood007
Member

If you don't issue an exit after the header then it will continue to process the script. Also should use redirectexit.

@colinschoen
Member
colinschoen commented Jan 5, 2017 edited

Sorry missed that. Or perhaps just an else surrounding the rest of the remaining logic.

@colinschoen colinschoen added a commit that referenced this pull request Jan 6, 2017
@colinschoen colinschoen Uses redirectexit and fixes #3798 (#3799)
* Use redirectexit instead of manually updating header

Signed-off-by: Colin Schoen <cschoen@berkeley.edu>

* More fixes

Signed-off-by: Colin Schoen <cschoen@berkeley.edu>

* Fix indentation

Signed-off-by: Colin Schoen <cschoen@berkeley.edu>
6812c1b
@live627 live627 deleted the live627:develop branch Jan 11, 2017
@live627 live627 modified the milestone: Beta 4, Beta 3 Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment