Uses redirectexit and fixes #3798 #3799

Merged
merged 3 commits into from Jan 6, 2017

Projects

None yet

2 participants

@colinschoen
Member

Use redirectexit instead of manually changing headers. Fixes #3798

@jdarwood007

colinschoen added some commits Jan 5, 2017
@colinschoen colinschoen Use redirectexit instead of manually updating header
Signed-off-by: Colin Schoen <cschoen@berkeley.edu>
dd4fbb2
@colinschoen colinschoen More fixes
Signed-off-by: Colin Schoen <cschoen@berkeley.edu>
f0926f9
@colinschoen colinschoen requested a review from live627 Jan 5, 2017
@colinschoen
Member

Fixing indentation, one moment...

@colinschoen colinschoen Fix indentation
Signed-off-by: Colin Schoen <cschoen@berkeley.edu>
784e5b2
@live627

redirectexit() calls obExit(), and the both of them combined are laced with arsenic and eat the image alive.

@colinschoen
Member
colinschoen commented Jan 5, 2017 edited

Working locally. What goes wrong when using them?

@live627
Contributor
live627 commented Jan 5, 2017

iDunno

  • Delete the image, refresh page
  • use image larger than threshold
@colinschoen
Member

Image larger than threshold is working. I'll try the other tomorrow

@colinschoen
Member
colinschoen commented Jan 5, 2017 edited

Deleting the image and refreshing the page is also working when checking out this PR locally. Not able to replicate any issues. @live627

@colinschoen
Member

iuemzpzeg7

@live627
live627 approved these changes Jan 5, 2017 View changes

Derp. I was testing against the wrong version.

@colinschoen
Member

No worries. Thanks for reviewing.

@colinschoen colinschoen merged commit 6812c1b into SimpleMachines:release-2.1 Jan 6, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment