Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use cache folder for db_last_error #4305
Also, Make sure we only verify minified files are writable if we have it enabled or have not set it yet.
Not all forums run with having world writable files in public folders. This changes this to use the cache folder. Which should be writable and per a admins configuration can be outside of the any public folders.
The only thing this doesn't cover it cleaning up Settings.php. But so far none of the other changes done also cleanup Settings.php or prep it for a improved upgraded version.
Signed-off-by: jdarwood007 firstname.lastname@example.org
Would you be willing to write some code to do that in the upgrader? Perhaps as part of another PR so that we can merge this one in the meantime.
I could look into that. Would it be too late in this stage to do that?
The only way I see this being possible is having the Settings.php as a template in the upgrader, injecting the updated variables into said template, then testing to make sure the variables match between the current and new one, then finally writing the file.