New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getVersion to Cache API #4306

Merged
merged 2 commits into from Oct 13, 2017

Conversation

Projects
None yet
3 participants
@jdarwood007
Member

jdarwood007 commented Sep 16, 2017

I haven't been able to properly test all of these, so please help with this. Most of them are borrowed from what Subs-Admin.php uses.

Signed-off-by: jdarwood007 unmonitored+github@sleepycode.com

jdarwood007 added some commits Sep 16, 2017

Add getVersion to Cache API
I haven't been able to properly test all of these, so please help with this.  Most of them are borrowed from what Subs-Admin.php uses.

Signed-off-by: jdarwood007 <unmonitored+github@sleepycode.com>
Woops, sent up wrong version
Signed-off-by: jdarwood007 <unmonitored+github@sleepycode.com>
@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Sep 17, 2017

Collaborator

The pg cache keep working,
did i see somewhere on the admin panel the version info (didn't find them)?

For pg/sql/file cache i miss a function/class method to implement house keeping,
idea would be once in a month or so to delete the old entries.

Collaborator

albertlast commented Sep 17, 2017

The pg cache keep working,
did i see somewhere on the admin panel the version info (didn't find them)?

For pg/sql/file cache i miss a function/class method to implement house keeping,
idea would be once in a month or so to delete the old entries.

@jdarwood007

This comment has been minimized.

Show comment
Hide comment
@jdarwood007

jdarwood007 Sep 17, 2017

Member

Wouldn't be a bad idea, can tie it into a scheduled task to do so.

Its in a few places in the ACP but they have to use the direct loading at this point unless I want to call the loadCacheAccelerator multiple times to get all of that. This fixes a call I missed in the admin panel and sets it up so we can get the version info easily. Mostly would be for support needs.

Member

jdarwood007 commented Sep 17, 2017

Wouldn't be a bad idea, can tie it into a scheduled task to do so.

Its in a few places in the ACP but they have to use the direct loading at this point unless I want to call the loadCacheAccelerator multiple times to get all of that. This fixes a call I missed in the admin panel and sets it up so we can get the version info easily. Mostly would be for support needs.

@jdarwood007 jdarwood007 added this to the RC 1 milestone Sep 17, 2017

@Oldiesmann Oldiesmann merged commit 11eb430 into SimpleMachines:release-2.1 Oct 13, 2017

2 checks passed

Scrutinizer 3 new issues, 11 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jdarwood007 jdarwood007 deleted the jdarwood007:cache_api branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment