New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2516 #4340

Merged
merged 3 commits into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@sbulen
Contributor

sbulen commented Sep 30, 2017

Fix cookie setting defaults in the installer:

  • The old logic looked for a subdomain in $boardurl, and attempted to set globalCookies if found. Three issues: (A) due to a problem with the preg_match, it never detects a subdomain, (B) it should mirror the ACP logic and also set globalCookiesDomain with the top-level-domain (TLD) but it does not, & (C) it is hard-coded to only recognize certain subdomains (e.g., forum, community, board) which is an unnecessary constraint, and worse, will not work for non-english languages. All 3 issues are addressed in this PR.
  • The old logic looked for a subfolder in $boardurl, and attempted to set localCookies if found. Due to an issue with the preg_match here, it will ONLY find sub-sub-folders (e.g., mysite.com/myboard will not be detected, but mysite.com/myboard/smf will be). This is addressed in this PR.

Tested in windows & linux, with subdomains & subfolders & without.

@sbulen sbulen referenced this pull request Sep 30, 2017

Closed

More bugs... #2516

sbulen added some commits Sep 29, 2017

Fix cookie setting defaults
Signed by Shawn Bulen, bulens@pacbell.net
Dont confuse subdomain with ipv4 address
Signed by Shawn Bulen, bulens@pacbell.net
Case insensitive replace
Signed by Shawn Bulen, bulens@pacbell.net

@Oldiesmann Oldiesmann added this to the RC 1 milestone Oct 13, 2017

@Oldiesmann Oldiesmann merged commit be0371a into SimpleMachines:release-2.1 Oct 13, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sbulen sbulen deleted the sbulen:cookie_defaults branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment