Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fulltext search edit - fixes #4387 #4388
There was a problem with the version check that prevented this from working properly.
Tested by creating fulltext indexes and performing searches on MyISAM and InnoDB. Also confirmed edit works properly by preventing creation of a fulltext index on MySQL 5.5 for InnoDB.
Since MariaDB supports the same engines (InnoDB and MyISAM), I don't think anything needs to change here to provide MariaDB support.
In theory, it is "drop-in" compatible with MySQL. Like Percona.
MariaDB offers several additional engines (Aria), but a lot more work would need to be done to support those. I don't think we want to go there.
The possible issue is that db_get_version returns 10.1.21-MariaDB instead of 5.7.0,
Yikes... Their numbering strayed.
So much for "drop in" compatibility. That is now out the door.
Looks like innodb supports fulltext from 10.0.5 on:
I think the MariaDB folks shot themselves in the foot.
I'm not so sure we can maintain a mapping of versions - it would have to be feature by feature, since they have abandoned MySQL version numbering. That is not a reasonable expectation. Over time, our code would have to be peppered with individual checks.
I will leave this as-is.