New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the favicon #4394

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
6 participants
@Gwenwyfar
Collaborator

Gwenwyfar commented Dec 4, 2017

It's using the same proportions as the new svg logo, and updated to contain all .ico favicon sizes. Total size could've been smaller but this image in particular kept resulting in a lot of aliasing in other converters.

Since it uses transparency it will work better for places outside the browser tab, and in different backgrounds. Color and style were a mix of old favicon vs new curve theme.

Samples:
favicon-sample
dark

Update the favicon
Signed-off-by: Gwenwyfar <gwenwyfar@protonmail.com>
@frandominguez03

Looking good

@illori

This comment has been minimized.

Show comment
Hide comment
@illori

illori Dec 5, 2017

Contributor

i would post this on the team boards to get further input, i am not sure if this violates our trademarks by doing this change to the image. as far as i know it has always been black inside the fulcrum and not the other way around, so this is a bit of a major change.

Contributor

illori commented Dec 5, 2017

i would post this on the team boards to get further input, i am not sure if this violates our trademarks by doing this change to the image. as far as i know it has always been black inside the fulcrum and not the other way around, so this is a bit of a major change.

@Antes

This comment has been minimized.

Show comment
Hide comment
@Antes

Antes Dec 5, 2017

Contributor

A very fine upgrade

Contributor

Antes commented Dec 5, 2017

A very fine upgrade

@colinschoen

Very nice work.

LGTM approval (pending no legal or trademark issues with this change. I’ll leave that discussion to the team boards per Illori’s suggestion)

@sbulen

This comment has been minimized.

Show comment
Hide comment
@sbulen

sbulen Dec 5, 2017

Contributor

To me, that looks like the logo on github for SMF.

Check here:
https://github.com/SimpleMachines

Contributor

sbulen commented Dec 5, 2017

To me, that looks like the logo on github for SMF.

Check here:
https://github.com/SimpleMachines

@Gwenwyfar

This comment has been minimized.

Show comment
Hide comment
@Gwenwyfar

Gwenwyfar Dec 5, 2017

Collaborator

@sbulen it is, that one was updated a few months back, and the previous (almost identical) one was one of the main bases for it. So the current Github logo, the new 2.1 header logo and this favicon are identical. Hoping we can update the others soon as well, once trademark issues are sorted :)

Collaborator

Gwenwyfar commented Dec 5, 2017

@sbulen it is, that one was updated a few months back, and the previous (almost identical) one was one of the main bases for it. So the current Github logo, the new 2.1 header logo and this favicon are identical. Hoping we can update the others soon as well, once trademark issues are sorted :)

@colinschoen

This comment has been minimized.

Show comment
Hide comment
@colinschoen

colinschoen Dec 6, 2017

Member

Per discussion in team boards this seems fine. Merging.

Member

colinschoen commented Dec 6, 2017

Per discussion in team boards this seems fine. Merging.

@colinschoen colinschoen merged commit e7eefc5 into SimpleMachines:release-2.1 Dec 6, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Gwenwyfar Gwenwyfar deleted the Gwenwyfar:favicon branch Dec 6, 2017

@Gwenwyfar Gwenwyfar added the Theme label Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment