New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite update to go with #4446 #4447

Merged
merged 10 commits into from Jan 24, 2018

Conversation

Projects
None yet
6 participants
@tinoest
Contributor

tinoest commented Dec 30, 2017

Update the Cache to work with the changes introduced by @albertlast

Slightly different mechanism as with testing the different between creating a new one and deleting was marginal.

root and others added some commits Dec 30, 2017

@Gwenwyfar Gwenwyfar added the Caching label Dec 30, 2017

@Oldiesmann

This comment has been minimized.

Show comment
Hide comment
@Oldiesmann

Oldiesmann Jan 8, 2018

Member

Your changes remove the closing php tag in each of the files you modified. This needs to be fixed before we can merge this.

Member

Oldiesmann commented Jan 8, 2018

Your changes remove the closing php tag in each of the files you modified. This needs to be fixed before we can merge this.

tinoest added some commits Jan 9, 2018

@Sesquipedalian

This comment has been minimized.

Show comment
Hide comment
@Sesquipedalian

Sesquipedalian Jan 10, 2018

Member

Need to trim off the line break after the closing PHP tag.

Member

Sesquipedalian commented Jan 10, 2018

Need to trim off the line break after the closing PHP tag.

@tinoest

This comment has been minimized.

Show comment
Hide comment
@tinoest

tinoest Jan 10, 2018

Contributor

There isn’t a line break showing in my editor. So no idea how I remove it

Contributor

tinoest commented Jan 10, 2018

There isn’t a line break showing in my editor. So no idea how I remove it

@frandominguez03

This comment has been minimized.

Show comment
Hide comment
@frandominguez03

frandominguez03 Jan 10, 2018

Member

That happened to me in some previous Pull Requests. Try pushing the changes by saving the files wirh Notepad++.

Are you using GitHub Desktop?

Member

frandominguez03 commented Jan 10, 2018

That happened to me in some previous Pull Requests. Try pushing the changes by saving the files wirh Notepad++.

Are you using GitHub Desktop?

@tinoest

This comment has been minimized.

Show comment
Hide comment
@tinoest

tinoest Jan 10, 2018

Contributor

I’m using macOS and Vim. I pushed with github desktop though.

Contributor

tinoest commented Jan 10, 2018

I’m using macOS and Vim. I pushed with github desktop though.

@frandominguez03

This comment has been minimized.

Show comment
Hide comment
@frandominguez03

frandominguez03 Jan 10, 2018

Member

Using GH Desktop, when you're about to commit you can see the changes made to that file. Try unchecking the line break by clicking on the blue box right to it, then commit, and discard the linea break changes after it.

Member

frandominguez03 commented Jan 10, 2018

Using GH Desktop, when you're about to commit you can see the changes made to that file. Try unchecking the line break by clicking on the blue box right to it, then commit, and discard the linea break changes after it.

@jdarwood007

This comment has been minimized.

Show comment
Hide comment
@Sesquipedalian

This comment has been minimized.

Show comment
Hide comment
@Sesquipedalian

Sesquipedalian Jan 11, 2018

Member

For a quick fix, perl -0777 -pi -e 's/\?>\n$/\?>/' file.php should do the job.

Member

Sesquipedalian commented Jan 11, 2018

For a quick fix, perl -0777 -pi -e 's/\?>\n$/\?>/' file.php should do the job.

tinoest added some commits Jan 12, 2018

@Sesquipedalian Sesquipedalian merged commit a828c15 into SimpleMachines:release-2.1 Jan 24, 2018

2 checks passed

Scrutinizer 1 new issues, 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment