New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smileys #4526

Merged
merged 3 commits into from Feb 9, 2018

Conversation

Projects
None yet
4 participants
@Gwenwyfar
Collaborator

Gwenwyfar commented Feb 4, 2018

The two sets that were removed will be going into smiley packages at the mod site. The upgrader may need proper updating, and it's also worth taking a close look to see if the installer is running properly.

Here's the changed smileys for the remaining 2 sets, top row is old files, bottom row new files.

smileys
smileys black

Fixes #2985

Gwenwyfar added some commits Jan 19, 2018

Remove old smiley sets
These will go in a smiley package later

Signed-off-by: Gwenwyfar <gwenwyfar@protonmail.com>
Make fugue the default smiley set
Signed-off-by: Gwenwyfar <gwenwyfar@protonmail.com>
Convert smileys to png and update the fugue set
Signed-off-by: Gwenwyfar <gwenwyfar@protonmail.com>

@Gwenwyfar Gwenwyfar added the Theme label Feb 4, 2018

@Gwenwyfar Gwenwyfar changed the title from Update smileys, fixes #2985 to Update smileys Feb 4, 2018

@Sesquipedalian Sesquipedalian merged commit 095e354 into SimpleMachines:release-2.1 Feb 9, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wintstar

This comment has been minimized.

wintstar commented Feb 9, 2018

No change in Database at Upgrade?

@Gwenwyfar

This comment has been minimized.

Collaborator

Gwenwyfar commented Feb 9, 2018

@Sesquipedalian did you check if the install/upgrade process is running correctly?

@Gwenwyfar Gwenwyfar deleted the Gwenwyfar:smileys branch Feb 9, 2018

@wintstar

This comment has been minimized.

wintstar commented Feb 9, 2018

Instalition is correct , but not Upgrade.

What about updating the smileys in the old posts? Changes made from. gif to. png?

smileys_broken

@Gwenwyfar

This comment has been minimized.

Collaborator

Gwenwyfar commented Feb 9, 2018

Well, like I said in the PR, it may need updating... I don't know how the upgrader works and I decided not to meddle with it until it was discussed.

@Sesquipedalian

This comment has been minimized.

Member

Sesquipedalian commented Feb 9, 2018

Dang, I forgot to test the upgrader.

@albertlast

This comment has been minimized.

Collaborator

albertlast commented Feb 9, 2018

No panic the fix you find in the pr #4532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment